Async routing improvements #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To return both result and invoked procedure at the same time. Previously procedure had to be accessed separately via getter. This is a preparation for async, where full result will make it easier to chain futures.
This commit makes `RoutingProcedureRunner` able to invoke routing procedures asynchronously using given connection future. Server version check is performed to determine which procedure to call.
This commit makes `ClusterCompositionProvider` able to interpret async responses from `RoutingProcedureRunner`.
This commit makes `LoadBalancer` able to serve async connections. Rediscovery procedure is also executed asynchronously. Connections returned by `LoadBalancer` have special error handling logic to remove failed instances from the routing table and purge their connections from the pool. Also made `AsyncConnection` expose server address and version instead of `ServerInfo`. Couple TODOs are introduced. They will be addressed in the subsequent commits.
This commit makes async `Rediscovery` use and respect routing retry delay exposed via `Config#withRoutingRetryDelay()` method. This is done by scheduling retries in Netty even loop. It's quite different compared to blocking version because we can't `Thread#sleep()` in async. Also added more unit tests for async rediscovery.
Previously load balancer selected a single address and tried to acquire connection for it. Connection failure would then surface to the user. This was done even though routing table could possibly contain other valid machines that might respond. This commit makes load balancer chain connection acquisition futures to probe all known machines before failure.
Better method location and naming, removed printout.
lutovich
force-pushed
the
1.5-async-routing-improvements
branch
from
2dfb470 to
e37d21e
Compare
lutovich
force-pushed
the
1.5-async-routing-improvements
branch
from
23d2e57 to
ca640ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR makes async routing respect
Config#withRoutingRetryDelay()setting and retry rediscovery configured amount of times with this delay. Retries are scheduled in Netty even loop. Also it makes load balancer "loop" until a working connection is acquired instead of failing on first failed acquisition attempt.Based on #409