Initial support for async in routing driver #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.5-async-routing
branch
from
2f633c2 to
d205c75
Compare
ali-ince
approved these changes
Oct 2, 2017
| @@ -33,11 +33,15 @@ | |||
| */ | |||
| BoltServerAddress selectReader( BoltServerAddress[] knownReaders ); | |||
|
|
|||
| BoltServerAddress selectReaderAsync( BoltServerAddress[] knownReaders ); | |||
| @@ -193,6 +286,21 @@ private BoltServerAddress selectAddress( AccessMode mode, AddressSet servers ) | |||
| } | |||
| } | |||
|
|
|||
| private BoltServerAddress selectAddressAsync( AccessMode mode, AddressSet servers ) | |||
There was a problem hiding this comment.
Do we need this sync/async distinction at this level? Do you have plans to implement selection differently in the future?
| @@ -47,11 +47,23 @@ public BoltServerAddress selectReader( BoltServerAddress[] knownReaders ) | |||
| } | |||
|
|
|||
| @Override | |||
| public BoltServerAddress selectReaderAsync( BoltServerAddress[] knownReaders ) | |||
| this.routingTable = routingTable; | ||
| this.rediscovery = rediscovery; | ||
| this.loadBalancingStrategy = loadBalancingStrategy; | ||
| this.log = log; | ||
|
|
||
| refreshRoutingTable(); | ||
| if ( connections != null ) |
There was a problem hiding this comment.
does this depend only on connections? Or should asyncConnectionPool has a say in the decision?
|
@ali-ince thanks for the review! I planned to get rid of those |
To return both result and invoked procedure at the same time. Previously procedure had to be accessed separately via getter. This is a preparation for async, where full result will make it easier to chain futures.
This commit makes `RoutingProcedureRunner` able to invoke routing procedures asynchronously using given connection future. Server version check is performed to determine which procedure to call.
This commit makes `ClusterCompositionProvider` able to interpret async responses from `RoutingProcedureRunner`.
This commit makes `LoadBalancer` able to serve async connections. Rediscovery procedure is also executed asynchronously. Connections returned by `LoadBalancer` have special error handling logic to remove failed instances from the routing table and purge their connections from the pool. Also made `AsyncConnection` expose server address and version instead of `ServerInfo`. Couple TODOs are introduced. They will be addressed in the subsequent commits.
lutovich
force-pushed
the
1.5-async-routing
branch
from
d205c75 to
c6ae295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.