-
Notifications
You must be signed in to change notification settings - Fork 155
Make driver-, session- and transaction config serializable. #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Wrong imports - Formatting changed
…ne implemented it, too.
I am in strong favor of this change, as we would gain serializable bookmarks with it, too… That makes things in several use-cases I recently discussed with @lqst a lot easier. As I pushed down the |
driver/src/test/java/org/neo4j/driver/TransactionConfigTest.java
Outdated
Show resolved
Hide resolved
@michael-simons, thanks a lot for taking care of this. @mattcasters, would you like to give it a spin to see if everything works as you expect? |
In Apache Hop we switched to google-java-format for reasons like this. Apache Beam is on Spotless / java checker framework. Pick your poison :-) |
Team checkstyle / Maven enforcer… :D |
4.4-SNAPSHOT driver works for the existing code. Now I'll try to use Config directly eliminating the wrapper code. |
I rewrote the Beam Neo4jIO to now allow Config, SessionConfig and TransactionConfig to be passed in since they're now Serializable. This works great! Awesome work guys, thanks a lot! |
@mattcasters, unless something urgent comes up, it might get released next week. |
Fantastic news! Thanks @injectives @michael-simons! |
Got stuck with usage of Value in TransactionConfig (for bookmarks) and usage of Optional for fetchSize in SessionConfig.
It's bound to be above my expertise to properly test this.