Skip to content

[Feature Request] Make Config, SessionConfig and TransactionConfig implement Serializable #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattcasters opened this issue Nov 15, 2021 · 1 comment
Closed

[Feature Request] Make Config, SessionConfig and TransactionConfig implement Serializable #1081

mattcasters opened this issue Nov 15, 2021 · 1 comment

Comments

@mattcasters
Copy link
Contributor

This is to make it easier to send these configurations across the network in a running Apache Beam pipeline.
The API of Beam asks for any metadata driving all transforms and functions to be Serializable. Reading from and writing to Neo4j is no exception to this. This requirement in turn forces us to mirror all methods of Config, SessionConfig and TransactionConfig in new Serializable classes and write new Builders for this as well.
@mattcasters mattcasters mentioned this issue Nov 15, 2021
Merged
4 tasks
injectives pushed a commit that referenced this issue Nov 19, 2021
@mattcasters @michael-simons
Make driver-, session- and transaction config serializable. (#1082)
ddb3959 
* Issue #1081

* Restore tests.

- Wrong imports
- Formatting changed

* Restore one more test.

* Cleanup session config test

* Don't use optional as field value, add test for session config.

* Don't try to serialize driver values.

* Cleanup config test

* Push down serializable into `InternalBook` for the obscure case someone implemented it, too.

* Add serialVersionUID's

* Make config correctly serialize

* More polishing.

* Apply suggestions.

Co-authored-by: Michael Simons <[email protected]>
@michael-simons
Copy link
Contributor

This has been implemented with #1082 in ddb3959.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michael-simons @mattcasters