-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-3111 Rename "Versioned API" to "Stable API" in documentation #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
884c6a7
6fbac7d
b6f17f1
468dc23
6686a56
e7bf545
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -590,7 +590,7 @@ def unpin(self): | |
|
||
def hello_cmd(self): | ||
# Handshake spec requires us to use OP_MSG+hello command for the | ||
# initial handshake in load balanced or versioned api mode. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @behackett see @blink1073's comment above about the other instances of Versioned API--I excluded those because the ticket says it's a docs change. Do comments fall under that? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might as well to avoid confusion from future maintainers. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good. |
||
# initial handshake in load balanced or stable API mode. | ||
if self.opts.server_api or self.hello_ok or self.opts.load_balanced: | ||
self.op_msg_enabled = True | ||
return SON([(HelloCompat.CMD, 1)]) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wait until the spec changes get merged so that we can update this line as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just remove this change and merge.