PYTHON-3111 Rename "Versioned API" to "Stable API" in documentation #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behackett
requested changes
Feb 11, 2022
pymongo/pool.py
Outdated
| @@ -590,7 +590,7 @@ def unpin(self): | |||
|
|
|||
| def hello_cmd(self): | |||
| # Handshake spec requires us to use OP_MSG+hello command for the | |||
| # initial handshake in load balanced or versioned api mode. | |||
| # initial handshake in load balanced or versioned API mode. | |||
blink1073
requested changes
Feb 14, 2022
juliusgeo
commented
Feb 14, 2022
| @@ -590,7 +590,7 @@ def unpin(self): | |||
|
|
|||
| def hello_cmd(self): | |||
| # Handshake spec requires us to use OP_MSG+hello command for the | |||
| # initial handshake in load balanced or versioned api mode. | |||
There was a problem hiding this comment.
@behackett see @blink1073's comment above about the other instances of Versioned API--I excluded those because the ticket says it's a docs change. Do comments fall under that?
There was a problem hiding this comment.
Might as well to avoid confusion from future maintainers.
blink1073
approved these changes
Feb 15, 2022
ShaneHarvey
reviewed
Feb 15, 2022
| @@ -134,7 +134,7 @@ do | |||
| uri|uri*options) | |||
| cpjson uri-options/tests uri_options | |||
| ;; | |||
| versioned-api) | |||
| stable-api) | |||
| cpjson versioned-api/tests versioned-api | |||
There was a problem hiding this comment.
Should we wait until the spec changes get merged so that we can update this line as well?
There was a problem hiding this comment.
Sounds good to me.
There was a problem hiding this comment.
Let's just remove this change and merge.
blink1073
pushed a commit
to blink1073/mongo-python-driver
that referenced
this pull request
Feb 25, 2022
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.