This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Windows codepage bugfix #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #869
When the path on a Windows machine is broken in such a way that chcp cannot be successfully invoked, an error occurs and the returned reason object does not have a code property as expected by the error handler. This results in the unhelpful error message
code=undefinedThere are two problems here:
Improved error handling
The catch clause checks whether
codeormessageproperties are present and falls back to stringifying the whole object.Reasonable default
The code page is 850 for the English speaking world. When a value cannot be obtained and the default is used a warning is generated that includes the error message returned from the attempt to invoke chcp.