-
Notifications
You must be signed in to change notification settings - Fork 236
Exit with code=undefined #869
Comments
I've got the same issue. Someone please look into this. |
@thangiot @KThen. have you try these steps? in #805 1.Open Arduino IDE to update board packages and compile the project. |
I've used many times this extension in the past and have no issues with it, this just occurs recently. I can't recall exactly when it happened, but I suspect it is not a problem with this extension, it might have something to do with recent VS Code updates. |
I am experiencing exactly as @KThen describes it, right down to the null reference in SerialMonitor.initialize I have ripped out VSCode and including all the files it leaves behind, and reinstalled it and the Arduino extension. I installed the Arduino IDE in version 1.8.8 because that version is blessed in the documentation, and was able to compile and deploy using that. I have the same set up on my notebook and it works perfectly there. The notebook doesn't have build 1903 because Microsoft is blocking it pending resolution of driver issues for Surface Book 2, but my desktop has been on 1903 for months now and this problem is quite recent. |
It works perfectly in a freshly built VM with Win10 1903 and latest everything. A key observation is that on my problem machine there is no output from log4j whereas on the fresh VM, output looks like this
This implies that there are settings in force on my problem machine suppressing logs among other things, which survived reinstallation of the Arduino IDE. In fact on that workstation I never saw log4j messages even when it was working. Any thoughts on what controls this? |
I spun up the extension in debug mode and
I broke up the parts of this expression and determined that the problem occurs in
This returns a useful message
WTF is How my path got broken is out of scope for this discussion. The key insight is that repairing it caused chcp to work resolving the code=undefined thing. The error handling is broken but the real problem is that unavailability of chcp makes the whole process fail. A reasonable fallback would be to default to 850 with a warning. I will do a PR. |
@PeterWone Thank you very much for your active participation and contribution. Before getting approval for your Pull Request, could you please fix the build failure with the Travis CI? |
@dooriya You're welcome.
Please look at #900 because the problem is your Linux build environment, not my code. Maybe you haven’t noticed but the main branch is failing in the same way for the same reason.
When I hand built a test environment using the latest Ubuntu I got the failure you want me to correct. When I hand built a test environment using the latest STABLE Ubuntu all tests passed.
The problem is that the Arduino IDE does not work on the latest Ubuntu. It works fine on the LTS build.
I looked at your build config and can't see why it would be using the latest Ubuntu, but there’s _something_ wrong. Maybe you should take a look at the Docker image.
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
…________________________________
From: Dooriya Li <[email protected]>
Sent: Thursday, September 26, 2019 6:38:19 PM
To: microsoft/vscode-arduino <[email protected]>
Cc: Peter Wone <[email protected]>; Mention <[email protected]>
Subject: Re: [microsoft/vscode-arduino] Exit with code=undefined (#869)
@PeterWone<https://github.com/PeterWone> Thank you very much for your active participation and contribution.
Before getting approval for your Pull Request<#899>, could you please fix the build failure with the Travis CI?
[image]<https://user-images.githubusercontent.com/10163840/65672412-96f8d580-e07b-11e9-9a8c-001a33ed4f2a.png>
Please try fixing the .travis.yml file as below:
[image]<https://user-images.githubusercontent.com/10163840/65672515-cad3fb00-e07b-11e9-82e1-c327ff49d814.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#869?email_source=notifications&email_token=ABJ6QOHHVUGNDF2WDB2A3A3QLRYHXA5CNFSM4IFRLVDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7UZN7Q#issuecomment-535402238>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABJ6QOEC4CIJMCOMKYML4DTQLRYHXANCNFSM4IFRLVDA>.
|
We've just fixed the Travis CI in master branch. |
Wow, that was quick! I'm on it. |
@dooriya This is the first time I've had to sync changes like this, I hope I've done this right. |
@PerterWone You make it :) I approved your PR, please feel free to merge it into master. We’ll add it into our next release. Thanks again for the contributions. |
@dooriya -- you say "feel free to merge it into master". Are you telling me that I have the necessary permissions to merge into microsoft/vscode-arduino ? What step should I now take? I do not know how to proceed. |
@PeterWone Sorry for that, it should be us to merge the PR. |
Not at all -- my ignorance of the workings of GitHub is hardly your fault. Thank you for helping me to get this done. |
Will update you once the new release is delivered. |
Using only `chcp` relies on the setting of environment variable PATHEXT. Related to microsoft#869
Using only `chcp` relies on the setting of environment variable PATHEXT. Related to microsoft#869
Using only `chcp` relies on the setting of environment variable PATHEXT. Related to #869
PR is merged with the fix, so close it here. |
The fix is released in Arduino 0.2.28. |
I've got the same problem #805 but I cannot solve my problems with these instructions in there. I used Arduino 1.8.9, vscode 1.36.1, Windows 10, Arduino Path: "C:\Program Files (x86)\Arduino" . Please help me, thanks.
arduino.json
c_cpp_properties.json
settings.json
Originally posted by @thangiot in #805 (comment)
The text was updated successfully, but these errors were encountered: