This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Fix board and library updates for CLI #1611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, refreshing the board index or library index simply attempted to install a board or library named "dummy", which doesn't make any sense in the Arduino CLI. Additional URLs from
arduino.additionalUrlswere also only written to a settings file but not passed to the Arduino CLI, so it was difficult to install third party boards or libraries.This PR changes that behavior to call
core update-indexorlib update-indexas appropriate, and wraps calls to the CLI to always pass the--additional-urlsflag.