This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Remove deploy and add Windows test to GH actions #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2022
benmcmorran
force-pushed
the
simplify-gh-actions
branch
from
db806c8 to
e526296
Compare
benmcmorran
changed the title
|
Note for myself: remove the now-obsolete |
aleun
approved these changes
Jan 6, 2022
| run: | | ||
| curl -LO https://downloads.arduino.cc/arduino-1.8.19-windows.zip | ||
| 7z x arduino-1.8.19-windows.zip -o"$Env:TEMP\arduino-ide" | ||
| echo "$Env:TEMP\arduino-ide\arduino-1.8.19" | Out-File -FilePath $env:GITHUB_PATH -Append |
There was a problem hiding this comment.
Would it be worthwhile to do a hash check on the download as well (like we're doing in the ADO pipeline)?
There was a problem hiding this comment.
Sure, I can add it. If we're going to do it on all 3 platforms, it's probably best to extract the inline node script to a separate file.
There was a problem hiding this comment.
Added for Linux and Windows. I'm leaving Mac alone for now because it installs through Homebrew. We could likely switch it to something closer to the Linux install, but I'll leave that for a future PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the ADO pipeline now handles creation of a GH release, we can simplify the GH actions to just provide quick build and test feedback across all platforms. It's worth keeping this on GH so that external contributors can inspect the build logs, which is impossible with ADO (by design).