Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Commit bf6d9ab

Browse files
benmcmorranbenmcmorran
authored
Merge pull request #1401 from microsoft/simplify-gh-actions
 Remove deploy and add Windows test to GH actions
2 parents dcd8a45 + c37e97b commit bf6d9ab

File tree

3 files changed

+74
-92
lines changed

3 files changed

+74
-92
lines changed

‎.github/workflows/build.yml

+55-88
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
name: CI-Tests
1+
# Copyright (c) Microsoft Corporation.
2+
# Licensed under the MIT License.
3+
4+
name: CI
5+
26
on:
37
push:
48
branches:
@@ -11,110 +15,73 @@ on:
1115
- master
1216
- dev
1317

14-
1518
jobs:
1619
build:
17-
runs-on: ${{ matrix.os }}
20+
runs-on: ${{ matrix.os }}
1821
strategy:
22+
fail-fast: false
1923
matrix:
2024
os: [ ubuntu-latest, macos-latest, windows-latest ]
21-
25+
2226
steps:
23-
- name: checkout
27+
- name: Checkout
2428
uses: actions/checkout@v2
25-
- name: get node
26-
uses: actions/setup-node@v1
29+
30+
# Node 14 matches the version of Node used by VS Code when this was
31+
# written, but it should be updated when VS Code updates its Node version.
32+
# Node needs to be installed before OS-specific setup so that we can run
33+
# the hash verification script.
34+
- name: Use Node 14.x
35+
uses: actions/setup-node@v2
2736
with:
28-
node-version: 11.x
29-
- name: linux setup
37+
node-version: 14.x
38+
39+
- name: Windows setup
40+
if: ${{ matrix.os == 'windows-latest' }}
41+
run: |
42+
curl -LO https://downloads.arduino.cc/arduino-1.8.19-windows.zip
43+
node build/checkHash.js arduino-1.8.19-windows.zip `
44+
c704a821089eab2588f1deae775916219b1517febd1dd574ff29958dca873945
45+
7z x arduino-1.8.19-windows.zip -o"$Env:TEMP\arduino-ide"
46+
echo "$Env:TEMP\arduino-ide\arduino-1.8.19" | Out-File -FilePath $env:GITHUB_PATH -Append
47+
- name: Linux setup
3048
if: ${{ matrix.os == 'ubuntu-latest' }}
3149
run: |
3250
export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
3351
sleep 3
34-
wget https://downloads.arduino.cc/arduino-1.8.2-linux64.tar.xz -P /home/$USER
35-
tar -xvf /home/$USER/arduino-1.8.2-linux64.tar.xz -C /home/$USER/
36-
sudo ln -s /home/$USER/arduino-1.8.2/arduino /usr/bin/arduino
52+
wget https://downloads.arduino.cc/arduino-1.8.19-linux64.tar.xz -P /home/$USER
53+
node build/checkHash.js /home/$USER/arduino-1.8.19-linux64.tar.xz \
54+
eb68bddc1d1c0120be2fca1350a03ee34531cf37f51847b21210b6e70545bc9b
55+
tar -xvf /home/$USER/arduino-1.8.19-linux64.tar.xz -C /home/$USER/
56+
sudo ln -s /home/$USER/arduino-1.8.19/arduino /usr/bin/arduino
3757
sudo apt-get update
38-
sudo apt-get install g++-multilib
39-
sudo apt-get install -y build-essential
40-
sudo apt-get install libudev-dev
41-
- name: macos setup
58+
sudo apt-get install -y g++-multilib build-essential libudev-dev
59+
- name: macOS setup
4260
if: ${{ matrix.os == 'macos-latest' }}
43-
run: |
61+
run: |
4462
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
4563
brew install arduino --cask
46-
- name: preinstall
47-
run: |
48-
npm install -g node-gyp
49-
npm install -g vsce@"^1.0.0"
50-
npm install -g gulp
51-
- name: install
52-
run: npm install
53-
- name: scripts
54-
run: |
55-
gulp tslint
56-
vsce package
57-
- name: run tests
64+
65+
# Windows agents already have gulp installed.
66+
- name: Install gulp
5867
if: ${{ matrix.os != 'windows-latest' }}
68+
run: npm install --global gulp
69+
- name: Install global dependencies
70+
run: npm install --global node-gyp vsce
71+
- name: Install project dependencies
72+
run: npm install
73+
74+
- name: Check for linting errors
75+
run: gulp tslint
76+
- name: Build and pack extension
77+
run: vsce package --out vscode-arduino.vsix
78+
- name: Publish extension VSIX as artifact
79+
uses: actions/upload-artifact@v2
80+
with:
81+
name: VS Code extension VSIX (${{ matrix.os }})
82+
path: vscode-arduino.vsix
83+
84+
- name: Run tests
5985
uses: GabrielBB/xvfb-action@v1
6086
with:
6187
run: npm test --silent
62-
63-
deploy:
64-
needs: build
65-
runs-on: ubuntu-latest
66-
environment: vsix-publishing
67-
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
68-
steps:
69-
- run: echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
70-
- run: echo ${{env.VERSION}}
71-
- name: Checkout
72-
uses: actions/checkout@v2
73-
- name: get node
74-
uses: actions/setup-node@v1
75-
with:
76-
node-version: 11.x
77-
- name: linux setup
78-
run: |
79-
export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
80-
sleep 3
81-
sudo apt-get update
82-
sudo apt-get install g++-multilib
83-
sudo apt-get install -y build-essential
84-
sudo apt-get install libudev-dev
85-
- name: preinstall
86-
run: |
87-
npm install -g node-gyp
88-
npm install -g vsce@"^1.0.0"
89-
npm install -g gulp
90-
- name: install
91-
run: npm install
92-
- name: scripts
93-
run: |
94-
gulp tslint
95-
gulp genAikey
96-
vsce package
97-
- name: upload .vsix to github tag
98-
uses: svenstaro/upload-release-action@v2
99-
with:
100-
repo_token: ${{ secrets.OAUTH_TOKEN }}
101-
file: ${{github.workspace}}/vscode-arduino*.vsix
102-
tag: ${{ github.ref }}
103-
overwrite: true
104-
file_glob: true
105-
- name: check for production tag
106-
id: check-version
107-
run: |
108-
if [[ ${{ env.VERSION }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
109-
echo ::set-output name=ISPRODUCTION::true
110-
fi
111-
# Skip attempting to publish for now, because I can't figure out how to
112-
# generate a valid VSCE_TOKEN. Instead we can manually publish by uploading
113-
# the release build artifact to the extension publisher site.
114-
- name: publish
115-
if: false && steps.check-version.outputs.ISPRODUCTION == 'true'
116-
env:
117-
PROD_AIKEY: ${{ secrets.PROD_AIKEY }}
118-
run: |
119-
gulp genAikey
120-
vsce publish -p ${{ secrets.VSCE_TOKEN }}

‎azure-pipelines.yml

+2-4
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,8 @@ steps:
6161
- script: curl -LO https://downloads.arduino.cc/arduino-1.8.19-windows.zip
6262
displayName: Download Arduino IDE
6363
- script: >-
64-
node --eval "process.exit(require('crypto').createHash('sha256').update(
65-
require('fs').readFileSync('arduino-1.8.19-windows.zip')).digest('hex')
66-
== 'c704a821089eab2588f1deae775916219b1517febd1dd574ff29958dca873945'
67-
? 0 : 1)"
64+
node build/checkHash.js arduino-1.8.19-windows.zip
65+
c704a821089eab2588f1deae775916219b1517febd1dd574ff29958dca873945
6866
displayName: Verify Arduino IDE
6967
- task: ExtractFiles@1
7068
displayName: Extract Arduino IDE

‎build/checkHash.js

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
4+
// Usage
5+
// $ node checkHash.js myfile.zip c704...3945
6+
// Returns with an exit code of zero if and only if the SHA-256 hash of the
7+
// given file matches the expected hash.
8+
9+
const path = process.argv[2];
10+
const expected = process.argv[3];
11+
const data = require('fs').readFileSync(path);
12+
const hash = require('crypto').createHash('sha256').update(data).digest('hex');
13+
if (hash !== expected) {
14+
console.error(
15+
`Expected SHA-256 of "${path}" to be ${expected} but found ${hash}.`);
16+
process.exit(1);
17+
}

0 commit comments

Comments
 (0)