-
Notifications
You must be signed in to change notification settings - Fork 236
Conversation
5a9ee34
to
6e4cfca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally and it addresses the issues.
This is close to a showstopper for using VSCode + Arduino with new developers/students- especially if trying to import an existing project. A partial workaround is to create a completely new folder, and then execute "Arduino-> initialize": this creates a new ino file and prompts for the board from the list of installed boards, and correctly generates the Arduino.json and c_cpp_properties files. Is it possible to get an ETA on when this can be approved? |
Just a bump so org members see this. |
Sorry about the delay everyone. I'm taking a look now. |
Looks like CI is broken (not your fault). I'm going to work on that in a separate PR, then come back and merge this. |
27dbf8c
to
6e4cfca
Compare
I also had to make the change in #1379 to support the case where an |
Awesome @benmcmorran, thank you! |
It all works now, thank you! |
This project is still running on react 15, and these
UNSAFE_*
-lifecycle aliases where not introduced until 16.3, hence they are never called.fixes #1163, fixes #1360, fixes #1363, fixes #1361, fixes #1372