Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Fix empty board and examples list #1367

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

fredr
Copy link
Contributor

@fredr fredr commented Oct 10, 2021

This project is still running on react 15, and these UNSAFE_*-lifecycle aliases where not introduced until 16.3, hence they are never called.

fixes #1163, fixes #1360, fixes #1363, fixes #1361, fixes #1372

@ghost
Copy link

ghost commented Oct 10, 2021

CLA assistant check
All CLA requirements met.

@fredr fredr changed the base branch from master to dev October 10, 2021 08:07
@fredr fredr force-pushed the fix/unsafe-lifecycles branch from 5a9ee34 to 6e4cfca Compare October 10, 2021 08:09
Copy link
Contributor

@maddogjt maddogjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and it addresses the issues.

@julianrendell
Copy link

This is close to a showstopper for using VSCode + Arduino with new developers/students- especially if trying to import an existing project.

A partial workaround is to create a completely new folder, and then execute "Arduino-> initialize": this creates a new ino file and prompts for the board from the list of installed boards, and correctly generates the Arduino.json and c_cpp_properties files.

Is it possible to get an ETA on when this can be approved?

@fredr fredr changed the title the UNSAFE_* lifecycle aliases where first introduced in react 16.3 Fix empty board and examples list Oct 19, 2021
@GXTX
Copy link

GXTX commented Nov 4, 2021

Just a bump so org members see this.
What is the status? This change is required to actually use this extension unless you downgrade.

@benmcmorran
Copy link
Member

Sorry about the delay everyone. I'm taking a look now.

@benmcmorran
Copy link
Member

Looks like CI is broken (not your fault). I'm going to work on that in a separate PR, then come back and merge this.

@benmcmorran benmcmorran force-pushed the fix/unsafe-lifecycles branch from 27dbf8c to 6e4cfca Compare November 5, 2021 23:00
@benmcmorran benmcmorran merged commit dad8b4b into microsoft:dev Nov 5, 2021
@benmcmorran
Copy link
Member

I also had to make the change in #1379 to support the case where an arduino.json file is not already present. I'm building a new release candidate now and if everything looks good I'll push it out to the marketplace.

@fredr fredr deleted the fix/unsafe-lifecycles branch November 6, 2021 07:55
@fredr
Copy link
Contributor Author

fredr commented Nov 6, 2021

Awesome @benmcmorran, thank you!

@AlexIII
Copy link

AlexIII commented Nov 6, 2021

It all works now, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants