Updated HTMLMediaElement.play return type to Promise<void> #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously the return type was void * According to https://html.spec.whatwg.org/multipage/embedded-content.html#dom-media-play it should be Promise<void>
|
@majames, |
|
@saschanaz can you please review this change? |
|
I'm not 100% sure about the policy, but if we prefer WHATWG spec over W3C one then LGTM, if not I think it should be |
|
I'd be happy to go with |
|
what do current browsers support? |
|
Firefox: Promise |
|
I would say it should be |
|
LGTM then 😄 |
|
thanks @majames and thanks @saschanaz for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #15691
microsoft/TypeScript#15691