Skip to content

Commit 0be887a

Browse files
authored
Merge pull request #249 from majames/fix/htmlmediaelement-returns-promise
Updated HTMLMediaElement.play return type to Promise<void>
2 parents d9e2bd8 + 982b8e5 commit 0be887a

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

baselines/dom.generated.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5725,7 +5725,7 @@ interface HTMLMediaElement extends HTMLElement {
57255725
/**
57265726
* Loads and starts playback of a media resource.
57275727
*/
5728-
play(): void;
5728+
play(): Promise<void>;
57295729
setMediaKeys(mediaKeys: MediaKeys | null): Promise<void>;
57305730
readonly HAVE_CURRENT_DATA: number;
57315731
readonly HAVE_ENOUGH_DATA: number;

inputfiles/overridingTypes.json

+8
Original file line numberDiff line numberDiff line change
@@ -1094,5 +1094,13 @@
10941094
"signatures": [
10951095
"new(data?: string): Text"
10961096
]
1097+
},
1098+
{
1099+
"kind": "method",
1100+
"interface": "HTMLMediaElement",
1101+
"name": "play",
1102+
"signatures": [
1103+
"play(): Promise<void>"
1104+
]
10971105
}
10981106
]

0 commit comments

Comments
 (0)