Skip to content

Commit 982b8e5

Browse files
author
Michael James
committed
Updated HTMLMediaElement.play return type to Promise<void>
* Previously the return type was void * According to https://html.spec.whatwg.org/multipage/embedded-content.html#dom-media-play it should be Promise<void>
1 parent fb07b70 commit 982b8e5

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

baselines/dom.generated.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5725,7 +5725,7 @@ interface HTMLMediaElement extends HTMLElement {
57255725
/**
57265726
* Loads and starts playback of a media resource.
57275727
*/
5728-
play(): void;
5728+
play(): Promise<void>;
57295729
setMediaKeys(mediaKeys: MediaKeys | null): Promise<void>;
57305730
readonly HAVE_CURRENT_DATA: number;
57315731
readonly HAVE_ENOUGH_DATA: number;

inputfiles/overridingTypes.json

+8
Original file line numberDiff line numberDiff line change
@@ -1073,5 +1073,13 @@
10731073
"signatures": [
10741074
"new(data?: string): Text"
10751075
]
1076+
},
1077+
{
1078+
"kind": "method",
1079+
"interface": "HTMLMediaElement",
1080+
"name": "play",
1081+
"signatures": [
1082+
"play(): Promise<void>"
1083+
]
10761084
}
10771085
]

0 commit comments

Comments
 (0)