Skip to content

Update HTMLMediaElement.preload type and comment #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Update HTMLMediaElement.preload type and comment #1113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6d74cf
Update HTMLMediaElement.preload type and comment
MartinJohns Aug 23, 2021
16474fd
Apply suggestions from code review
MartinJohns Aug 23, 2021
feb4cbc
Run baseline-accept on changes from code review
MartinJohns Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6940,8 +6940,8 @@ interface HTMLMediaElement extends HTMLElement {
playbackRate: number;
/** Gets TimeRanges for the current media resource that has been played. */
readonly played: TimeRanges;
/** Gets or sets the current playback position, in seconds. */
preload: string;
/** Gets or sets a value indicating what data should be preloaded, if any. */
preload: "none" | "metadata" | "auto";
readonly readyState: number;
readonly remote: RemotePlayback;
/** Returns a TimeRanges object that represents the ranges of the current media resource that can be seeked. */
Expand Down
2 changes: 1 addition & 1 deletion inputfiles/comments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,7 +1554,7 @@
"comment": "Gets or sets the current playback position, in seconds."
},
"preload": {
"comment": "Gets or sets the current playback position, in seconds."
"comment": "Gets or sets a value indicating what data should be preloaded, if any."
},
"networkState": {
"comment": "Gets the current network activity for the element."
Expand Down
10 changes: 10 additions & 0 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2792,6 +2792,16 @@
}
}
}
},
"HTMLMediaElement": {
"properties": {
"property": {
"preload": {
"name": "preload",
"overrideType": "\"none\" | \"metadata\" | \"auto\""
}
}
}
}
}
},
Expand Down