Skip to content

Update HTMLMediaElement.preload type and comment #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 23, 2021
Merged

Update HTMLMediaElement.preload type and comment #1113

merged 3 commits into from
Aug 23, 2021

Conversation

MartinJohns
Copy link
Contributor

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@MartinJohns
Copy link
Contributor Author

This PR contains a breaking change, which is acceptable according to Ryans comment.

@MartinJohns MartinJohns mentioned this pull request Aug 23, 2021
Closed
saschanaz
saschanaz suggested changes Aug 23, 2021
View reviewed changes
@saschanaz
Copy link
Contributor

LGTM

@github-actions github-actions bot merged commit 5b72865 into microsoft:main Aug 23, 2021
@github-actions
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTMLMediaElement.preload has wrong documentation
2 participants
@MartinJohns @saschanaz