-
Notifications
You must be signed in to change notification settings - Fork 440
Add disposition field to SecurityPolicyViolationEvent #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disposition field to SecurityPolicyViolationEvent #1031
Conversation
"name": "disposition", | ||
"default": "\"\"", | ||
"type": "DOMString", | ||
"type-original": "DOMString" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this manually added to the JSON? It might get removed by the next update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @orta, yes I manually added otherwise npm run test
fails. I am totally new to this, if you can tell me what is the correct way to do it I will be grateful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some good docs in the README on how to update an IDL: https://github.com/microsoft/TypeScript-DOM-lib-generator#contribution-guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it, thanks.
6df7c71
to
ed9be74
Compare
ed9be74
to
d2d4439
Compare
The old BCD filter implementation of the current master branch can't filter the types from |
Fixed by #1034 @github-actions close |
Closing because @saschanaz is a code-owner of all the changes. |
lib Update Request
Configuration Check
My compilation target is
ES2015
and my lib is["esnext", "dom"]
.Missing / Incorrect Definition
the interface SecurityPolicyViolationEvent is missing the
disposition
field.Sample Code
Documentation Link
According to https://www.w3.org/TR/CSP3/#violation-events, the interface SecurityPolicyViolationEvent has a field called disposition. This field is present in Chrome, Firefox, Safari.