Skip to content

Should we keep track of the last date an IDL was processed as a baseline? #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orta opened this issue Jun 29, 2021 · 3 comments
Closed

Comments

@orta
Copy link
Contributor

orta commented Jun 29, 2021

For a PR like #1031 - I'm not certain if this was done via the IDL generator, or hand added in the JSON (as that probably seems like the easiest way as a first time contributor)

If we had a JSON file which had the dates the last time a IDL was processed (which gets updated when someone runs the scripts) then we can know in a PR that it isn't a temporary change

@saschanaz
Copy link
Contributor

The IDL generator never touches browser.webidl.preprocessed.json and it should not be modified by anything. That's why https://github.com/microsoft/TypeScript-DOM-lib-generator/commits/master/inputfiles/browser.webidl.preprocessed.json is very short (and it means #662 was wrong).

@saschanaz
Copy link
Contributor

saschanaz commented Oct 4, 2021

Closing this as there is no browser.webidl.preprocessed.json anymore nor local IDL files

@github-actions close

@github-actions github-actions bot closed this as completed Oct 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2021

Closing because @saschanaz is one of the code-owners of this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants