Add a windowRef option to initLoginFlowInPopup to prevent the window from beeing blocked by popup blockers #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the link path to the ".html" page instead of ".md". In the path "https://manfredsteyer.github.io/angular-oauth2-oidc/docs/additional-documentation/silent-refresh.html" the "Token Refresh" link is not pointing to the html page.
…from beeing blocked by popup blockers
fix: Disable nonce validation for id token for e2e tests
…ime-provider Feature: DateTimeProvider
Remove unused variable
Changes the link path " Token Refresh"
Custom grant type added
Listen for storage to receive auth hash from popup
This was referenced Jul 17, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running into the problem, that when a window.open is called inside a promise browsers like firefox seem to be not able anymore to detect the original click event. This causes the popup blocker to block the window opened for login.
A workaround would be opening the window and after this running the promise with the login popup, giving it the promise as a reference like done in this jsfiddle in another context: https://jsfiddle.net/mxwtjkuo/