Skip to content

Feature: DateTimeProvider #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 16, 2021
Merged

Feature: DateTimeProvider #874

merged 5 commits into from
Jul 16, 2021

Conversation

ManuelRauber
Copy link

Hi @manfredsteyer & @jeroenheijmans

I had some spare time and I've reworked #596.

  • Added sample
  • Added docs

I did not include tests, according to

love tests, especially for libs like this repo, but only like it if we'd go all-in (and not add only a couple of tests, which IMHO adds a false sense of security)
(#596 (comment))

@ManuelRauber
Copy link
Author

Rebased the branch due to yesterday's push from Manfred.

@manfredsteyer manfredsteyer merged commit 2c0d16b into manfredsteyer:master Jul 16, 2021
@manfredsteyer
Copy link
Owner

Awesome. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManuelRauber @manfredsteyer