-
Notifications
You must be signed in to change notification settings - Fork 694
Skip issuer check in processIdToken if skipIssuerCheck is true #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ssuerCheck is true
What is the status of this PR? |
We are in need of this fix to support multi-tenancy. We have Azure Active directory as a common identity system and the issuer varies based on the Azure Active directory (different organizations). We make issuer checks through application logic after the user has logged in. |
We are also waiting for this PR to be merged and a new minor release after that. @jeroenheijmans It would be great if you have time for this and check the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look sensible to me. 👍
Good thing a new major release is in the making, as this might impact existing users in ways we haven't anticipated.
Might also fix #523, I believe? |
Is there any progress on this ? Will be a 5.0.3 in the near future ? Thanks. |
Status/progress is up to the maintainer, but either way I would not expect a 5.0.3 version (based on this): if this PR gets merged it'd probably go into a 8.x version. |
Great to hear about version 8. With or without this PR, I hope to see this fix/enhancement in v8 😄. Thanks a lot for the information. |
Don't think the newest commit (9ca6b23) is appropriate. The upgrade of packages doesn't seem to belong in this PR, and the change of the package name certainly doesn't belong here (unless I'm missing something?). |
This reverts commit 9ca6b23.
@jeroenheijmans sorry it was a mistake, I have reverted the commit. |
Resolves #492