-
Notifications
You must be signed in to change notification settings - Fork 694
Wrong issuer: accounts.google.com #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It seems that OAuth2 (RFC7519) allows a
So Google is being a pain here, by providing different values during discovery and inside the token. It was noted in other projects too that this occurs, the conclusion there seems similar: a workaround is needed. I saw you already created a PR for this, #524 (that was probably intending to reference this issue in the "fixes" message?), I'll comment there on the proposed solution. Careful by the way that there may be more trouble ahead for you with Google's auth, I remember #364 that shows some issues with the origin of the iframe parent. |
I think as per this comment things got fixed in the latest version. Let us know if the issue persists and we could reopen this issue! |
For Google, the issuer check fails in
processIdTokken
. The discovery document of google (https://accounts.google.com/.well-known/openid-configuration) stateswhile the token contains
This might be a bug on Google's side (or maybe the spec is not clear whether the issuer refers only to the host part of the URL), but it would help if the library could cope with it.
BTW, I also tried specifying the issuer as
accounts.google.com
in the config, but then I can't even load the discovery document.How are other user dealing with this issue?
The text was updated successfully, but these errors were encountered: