Skip to content

Fix/changed files #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 81 commits into from
Closed

Fix/changed files #47

wants to merge 81 commits into from

Conversation

lucasssvaz
Copy link
Owner

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

Please describe your proposed Pull Request and it's impact.

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

is-qian and others added 30 commits January 21, 2025 13:24
* feat(esp32): Added a new device(xiao esp32s3 plus)

* Update boards.txt

* Apply suggestions from code review

* Fix filename error.

* Fix filename error.

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: Jan Procházka <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…eEP.h (espressif#10821)

* Update ZigbeeHandlers.cpp

* Update ZigbeeEP.h

* Update ZigbeeEP.h

make addBoundDevice virtual for override

* fix(zigbee): Update and reorder handlers

* fix(zigbee): Place default handler to the end

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: Jan Procházka <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…#10896)

* fix(littlefs): Converted core disableWDT functions to bool

* Missed the returns on core1

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…luster (espressif#10863)

* feat(zigbee): Add Time cluster support

* fix(zigbee): Remove duplicate of identify cluster

* feat(zigbee): Remove unused variables in addTimeCluster

* feat(zigbee): Update examples with optional Time cluster

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
The certificate is outdated. The current certificate can be found using `openssl s_client -showcerts -connect jigsaw.w3.org:443`
* fix(logging): Corrected FPS calculation

Previously, last_frame was only updated once at the beginning of stream_handler,
leading to incorrect FPS and avg_frame_time computation.

This commit ensures last_frame is updated on each iteration after last FPS computation,
resulting in accurate FPS logging.

Fixes espressif#10920

* Revert "fix(logging): Corrected FPS calculation"

This reverts commit 0bb7b95.

* fix(loggin): Incorrect FPS computation fixed

Corrected and tested change in FPS computation, suggested by @me-no-dev and found working with correct numbers.

Previously, last_frame was only updated once at the beginning of stream_handler,
leading to incorrect FPS and avg_frame_time computation.

This commit ensures last_frame is updated on each iteration after last FPS computation,
resulting in accurate FPS logging.

Fixes espressif#10920
Wrong pins were used for baud rate detection test case, therefore no data was reaching UART1 RX FIFO from UART0 TX loopback.
Adding ESP-SR to the documentation

Co-authored-by: Me No Dev <[email protected]>
…ndle) (espressif#10918)

* feat(zigbee): Add IAS Zone endpoints

* ci(pre-commit): Apply automatic fixes

* fix(ci): Typo fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* feat(net): Allow for event task custom stack size

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: Me No Dev <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* feat(zigbee): Added Endpoint for Window Covering (espressif#10913)

* Added example Sketch.

* Added window covering to CMakeLists.txt.

* feat(zigbee): Window covering tilt support and fixes

* fix(zigbee): Fix typos

* ci(pre-commit): Apply automatic fixes

* fix(ci): Fixes of typos

---------

Co-authored-by: Jan Procházka <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix(i2s): Add missing initializer for I2S CLK config

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* feat(cdc): Add support for two CDC ports at once

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…ssif#10961)

Bumps [cryptography](https://github.com/pyca/cryptography) from 43.0.1 to 44.0.1.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@43.0.1...44.0.1)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(zigbee): Add OTA client cluster support

* feat(zigbee): Add conditions to reject OTA upgrade

* feat(zigbee): Add newest version of OTA handler

* fix(zigbee): Fix errors and warnings, swap parameters order

* feat(zigbee): Add simple OTA Client example

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* IDF release/v5.3 adf53196

* IDF release/v5.3 fb25eb02

* IDF release/v5.3 fb25eb02

* IDF release/v5.3 fb25eb02

* IDF release/v5.3 fb25eb02

* IDF release/v5.3 489d7a2b
…essif#10959)

* feat(zigbee): Support HSV color commands

* ci(pre-commit): Apply automatic fixes

* feat(zigbee): Add hue and sat attributes and update color capabilities

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: Me No Dev <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
)

* feat(board): Update 3rd party board Huidu HD-WF2/HD-WF4

Followup espressif#10779

 - fixed flash mode to 'dio'
 - removed psram flags
 - corrected gpio mapping defines

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…spressif#10945)

Fixes: espressif#10938
Keep allocated memory when rhs fits

Use case: Appending to a String with pre-allocated memory (e.g. from `reserve()`)
No need to move 0-termination char in String::move
Simplify calls to String::copy

A lot of the same checks were done before calling `copy()` which should be done in the `copy()` function itself.
String::copy() Should not copy more than given length
Fix potential out of range in String::concat

There is no prerequisite the given array has to be a 0-terminated char array.
So we should only copy the length that has been given.

The `setLen()` function will make sure the internal string is 0-terminated.
So no need to dangerously assume there will be 1 more byte to copy
Allow String::concat(const String &s) with s.buffer() == nullptr

When constructing a String object, the internal buffer is a nullptr.
However concatenating this to another String would return `false` while this is perfectly fine to do.
me-no-dev and others added 26 commits February 25, 2025 10:13
* IDF release/v5.4 bcb3c32d

* fix(zigbee): Remove the need of native ieee802154 radio

---------

Co-authored-by: Jan Procházka <[email protected]>
…rd (espressif#10947)

* Adding CYObot board - 3rd party board

1. Adding Pin Header file for CYObot to variants folder
2. Add CYObot config to boards.txt

* feat(cyobot): adding cyobot_v2_esp32s3 board

Change comments in pin header file for cyobot board

* fix(cyobot_v2_esp32s3): fix variant name

fix variant name for cyobot board

* fix(boards.txt): fix name of CYOBot board

- Change name to uppercase

* fix(CYOBot): fix boards.txt & pin_arduino.h

* fix(pins_arduino.h): capitalize name

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* ci(zigbee): Check if Zigbee is enabled for CI tests

* ci(zigbee): Fix requirements

* fix(zigbee): Use LED_BUILTIN for range extender

* fix(zigbee): Use default GPIO if LED_BUILTINnot defined
espressif#11009)

* fix(zigbee): Remove the need of native ieee802154 radio

* feat(zigbee): Add ZigbeeGateway endpoint support

* fix(zigbee): Fix TimeCluster missing status attribute

* feat(zigbee): Add new src to CMakeLists

* feaz(zigbee): Update keywords.txt with latest updates

* feat(zigbee): Add 8MB Zigbee ZCZR partitions to other socs

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Garcia <[email protected]>
…ance (espressif#11015)

* fix(zigbee): use correct carbon dioxide cluster function in setTolerance

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix(bt): Fix compile error on ESP32-P4

* fix(bt): Fix compile error on ESP32-P4
* test(i2c): Add test to scan bus

* test(i2c): Add scan test with wifi running

* fix(i2c): Simplify test
…spressif#11042)

* feat(matter): necessary changes to insights version for esp_matter

* feat(rainmaker): update RainMaker version to 1.5.2
…spressif#11016)

* feat(gpio): allows mixing digital and analog read/write operations

* fix(gpio): simple mistake in calling __pinMode() fnuction

* fix(gpio): simple mistake in calling __pinMode() fnuction

* feat(gpio): update the log message to tell the solution for the error.

* feat(gpio): warn user about digitalRead() used with non GPIO pin

* fix(gpio): wrong peripheral manager test case
Fix to a copy-paste error that causes a Guru Meditation crash with Zigbee Analog Example.
…if#11052)

* fix(wifi): Disable properly LR mode if it was enabled before

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…ssif#11053)

* feat(eth): Add setters for negotiation, speed and duplex modes

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…essages (espressif#11067)

* fix(matter): uninitialized fields warning

* fix(matter): uninitialized fields warning
…) and before digitalWrite() (espressif#11070)

* fix(matter): itshall set digital mode before digitalWrite

* fix(matter): example must set pin in digital mode before writting

* fix(matter): example shall set digital mode before writing

* fix(matter): digitalMode necessary before digitalWrite(LOW)

* fix(matter): example must set digital mode after analogwrite

* fix(matter): wrong copy paste

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix(network): fixes a macro name conflict warning

* feat(networking): removed local maco definition in favor of IDF one
* Create ZigbeeWindSpeedSensor.h

* Create ZigbeeWindSpeedSensor.cpp

* Update ZigbeeWindSpeedSensor.cpp

* Update ZigbeeWindSpeedSensor.cpp

* Create ZigbeeWindSpeedSensor.ino

* Update ZigbeeWindSpeedSensor.ino

* Update ZigbeeWindSpeedSensor.ino

* Create ci.json

* Rename ZigbeeWindSpeedSensor.ino to Zigbee_Wind_Speed_Sensor.ino

* Rename ci.json to ci.json

* Update CMakeLists.txt

* Update Zigbee_Wind_Speed_Sensor.ino

* Update Zigbee_Wind_Speed_Sensor.ino

* Update Zigbee_Wind_Speed_Sensor.ino

* Update ZigbeeWindSpeedSensor.cpp

* Update ZigbeeWindSpeedSensor.cpp

Use ESP_ZB_HA_SIMPLE_SENSOR_DEVICE_ID device id

* feat(zigbee): Add windspeed sensor endpoint

* Update Zigbee.h

Add ZigbeeWindSpeedSensor.h

* update example

* add missing sdkconfig include

* add readme

* ci(pre-commit): Apply automatic fixes

* Update README.md

---------

Co-authored-by: Jan Procházka <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…essif#11080)

* test(i2c): Do not use delta as Wokwi timing can be inconsistent

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Copy link

github-actions bot commented Mar 15, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message " fix(zigbee): use correct carbon dioxide cluster function in setTolerance (#11015)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add IAS Zone Notification Message service to ZigbeeHandlers and ZigbeeEP.h (#10821)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add the latest versions to issue report template":
    • summary looks empty
    • type/action looks empty
  • the commit message "Created Zigbee Endpoint for Window Covering. (#10914)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix HardwareSerial config (#11007)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix crash in String when using nullptr (#10971) (#10972)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix crash when using String::move on empty string (#10938) (#10945)":
    • footer's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix to issue #11044 (#11064)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 (#10873)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.4 (#10998)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.4 d4aa25a3 (#11060)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.4 e37d33cc (#10980)":
    • summary looks empty
    • type/action looks empty
  • the commit message "NetworkEvents allow stack size to be changed. (#10805)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update HTTPS certificate in BasicHttpsClient.ino (#10911)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Update README.md to add ESP-SR (#10925)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update core version to 3.1.2":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update core version to 3.1.3":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update core version to 3.2.0":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update of Boards.txt & variants - Adding CYObot board - 3rd party board (#10947)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update pins_arduino.h (#11000)":
    • summary looks empty
    • type/action looks empty
  • the commit message "build(deps): bump cryptography from 43.0.1 to 44.0.1 in /tests (#10961)":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "feat(LP_UART): Implements the ESP32-C6/ESP32-P4 Low Power UART as a possible HardwareSerial port (#10967)":
    • summary appears to be too long
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Zigbee): Adding Zigbee Wind speed sensor endpoint (#10455)":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "fix":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix(SPIFFS): Use new disableWDT bool return value (#10909)":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "fix(logging): incorrect FPS logging (#10921)":
    • footer's lines must not be longer than 100 characters
  • the commit message "fix(matter): examples must set pin to Digital Mode after analogWrite() and before digitalWrite() (#11070)":
    • summary appears to be too long
  • the commit message "fix(matter): removes a few matter 1.4 / IDF 5.4 compilation warning messages (#11067)":
    • summary appears to be too long
  • the commit message "fix(uart): fixed esp32s2 uart ci test case (#10926)":
    • body's lines must not be longer than 100 characters

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 This PR seems to be quite large (total lines of code: 7832), you might consider splitting it into smaller PRs

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3304ae0

@lucasssvaz lucasssvaz closed this Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.