NetworkEvents allow stack size to be changed.

[thekurtovic]

Description of Change

Replaced hardcoded stack size value for "arduino_events" task. Defaults to the original value. Application may override the value with a build flag i.e. -D ARDUINO_NETWORK_EVENT_TASK_STACK_SIZE=8192

Tests scenarios

N/A

Related links

N/A

[CLAassistant]

All committers have signed the CLA.

[github-actions]

	Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello thekurtovic, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2d0c10a

[vortigont]

I'm wondering if we'd better reuse default event loop's task for this also?

[me-no-dev]

@vortigont not sure I understand what you mean?

[vortigont]

Hi @me-no-dev,
what I wanted to highlight is that currently NetworkEvents implementation uses it's own RTOS queue and task to generate/propagate and run callbacks for Network events. While IDF has exactly same thing implemented and used for similar network/Bluetooth event handling via Event Loop Library. An example from IDF. Under the hood it has same set of objects - a queue and a handling task, the default instance is created here. As soon as WiFi or BT code is used in the project this default event loop is started anyway.
So maybe reusing this queue could a feasible approach - at least we could save resources for same and reuse the IDF's event API.

I can reimplement NetworkEvents class over event loop's API if there is an interest in this.

[github-actions]

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32P4	0	0	0.00	0.00	0	0	0.00	0.00
ESP32S3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32S2	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C6	0	0	0.00	0.00	0	0	0.00	0.00
ESP32H2	0	0	0.00	0.00	0	0	0.00	0.00
ESP32	0	0	0.00	0.00	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32P4		ESP32S3		ESP32S2		ESP32C3		ESP32C6		ESP32H2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
Ethernet/examples/ETH_TLK110	0	0	-	-	-	-	-	-	-	-	-	-	0	0
Ethernet/examples/ETH_W5500_Arduino_SPI	0	0	0	0	0	0	0	0	0	0	0	0	0	0
Ethernet/examples/ETH_W5500_IDF_SPI	0	0	0	0	0	0	0	0	0	0	0	0	0	0
Ethernet/examples/ETH_WIFI_BRIDGE	0	0	0	0	0	0	0	0	0	0	-	-	0	0
NetworkClientSecure/examples/WiFiClientInsecure	0	0	0	0	0	0	0	0	0	0	-	-	0	0
NetworkClientSecure/examples/WiFiClientPSK	0	0	0	0	0	0	0	0	0	0	-	-	0	0
NetworkClientSecure/examples/WiFiClientSecure	0	0	0	0	0	0	0	0	0	0	-	-	0	0
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade	0	0	0	0	0	0	0	0	0	0	-	-	0	0
NetworkClientSecure/examples/WiFiClientShowPeerCredentials	0	0	0	0	0	0	0	0	0	0	-	-	0	0
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse	0	0	0	0	0	0	0	0	0	0	-	-	0	0
PPP/examples/PPP_Basic	0	0	0	0	0	0	0	0	0	0	0	0	0	0
PPP/examples/PPP_WIFI_BRIDGE	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/AdvancedWebServer	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/FSBrowser	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/Filters	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/HelloServer	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/HttpAdvancedAuth	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/HttpAuthCallback	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/HttpAuthCallbackInline	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/HttpBasicAuth	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/HttpBasicAuthSHA1	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/HttpBasicAuthSHA1orBearerToken	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/MultiHomedServers	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/PathArgServer	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/SDWebServer	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/SimpleAuthentification	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/UploadHugeFile	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/WebServer	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/WebUpdate	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/FTM/FTM_Initiator	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/FTM/FTM_Responder	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/SimpleWiFiServer	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiAccessPoint	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiClient	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiClientBasic	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiClientConnect	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiClientEvents	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiClientStaticIP	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiExtender	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiIPv6	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiMulti	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiMultiAdvanced	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiScan	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiScanAsync	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiScanDualAntenna	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiScanTime	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiTelnetToSerial	0	0	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiUDPClient	0	0	0	0	0	0	0	0	0	0	-	-	0	0
NetworkClientSecure/examples/WiFiClientSecureEnterprise	-	-	0	0	0	0	0	0	0	0	-	-	0	0
WebServer/examples/Middleware	-	-	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WPS	-	-	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiBlueToothSwitch	-	-	0	0	-	-	0	0	0	0	-	-	0	0
WiFi/examples/WiFiClientEnterprise	-	-	0	0	0	0	0	0	0	0	-	-	0	0
WiFi/examples/WiFiSmartConfig	-	-	0	0	0	0	0	0	0	0	-	-	0	0
Ethernet/examples/ETH_LAN8720	-	-	-	-	-	-	-	-	-	-	-	-	0	0

[github-actions]

Test Results

 62 files   62 suites   5m 39s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
153 runs  153 ✅ 0 💤 0 ❌

Results for commit 2d0c10a.

♻️ This comment has been updated with latest results.

[thekurtovic]

@vortigont I think this sounds like a cool idea and would be worth opening a PR