TypeError: Object [object Object] has no method 'release' #109

elhoyos · 2015-09-24T18:51:19Z

I'm having this error when issuing a SELECT and then doing a #rollback to close the transaction without actually doing other operation.

2015-09-24T18:31:11.750Z pid:2371 worker:36 Thu, 24 Sep 2015 18:31:11 GMT loopback:connector:postgresql SQL: SELECT "field","id" FROM "schema"."table" WHERE "field"=$1 ORDER BY "id"
2015-09-24T18:31:11.750Z pid:2371 worker:36 Parameters: ["foo"]
2015-09-24T18:31:11.750Z pid:2371 worker:36 Thu, 24 Sep 2015 18:31:11 GMT loopback:connector:postgresql Execute SQL within a transaction
2015-09-24T18:31:11.752Z pid:2371 worker:36 events.js:72
2015-09-24T18:31:11.752Z pid:2371 worker:36         throw er; // Unhandled 'error' event
2015-09-24T18:31:11.752Z pid:2371 worker:36               ^
2015-09-24T18:31:11.754Z pid:2371 worker:36 TypeError: Object [object Object] has no method 'release'
2015-09-24T18:31:11.754Z pid:2371 worker:36     at PostgreSQL.releaseConnection (/home/myapp/node_modules/loopback-connector-postgresql/lib/transaction.js:70:14)
2015-09-24T18:31:11.754Z pid:2371 worker:36     at null.<anonymous> (/home/myapp/node_modules/loopback-connector-postgresql/lib/transaction.js:56:12)
2015-09-24T18:31:11.755Z pid:2371 worker:36     at Object.forward (/home/ubuntu/.nvm/v0.10.38/lib/node_modules/strongloop/node_modules/strong-agent/lib/proxy.js:79:23)
2015-09-24T18:31:11.755Z pid:2371 worker:36     at eval (eval at wrap (/home/ubuntu/.nvm/v0.10.38/lib/node_modules/strongloop/node_modules/strong-agent/lib/proxy.js:193:20), <anonymous>:3:21)
2015-09-24T18:31:11.755Z pid:2371 worker:36     at null.<anonymous> (/home/myapp/node_modules/loopback/node_modules/continuation-local-storage/context.js:74:17)
2015-09-24T18:31:11.755Z pid:2371 worker:36     at b [as callback] (domain.js:183:18)
2015-09-24T18:31:11.755Z pid:2371 worker:36     at Query.handleReadyForQuery (/home/myapp/node_modules/loopback-connector-postgresql/node_modules/pg/lib/query.js:89:10)
2015-09-24T18:31:11.755Z pid:2371 worker:36     at null.<anonymous> (/home/myapp/node_modules/loopback-connector-postgresql/node_modules/pg/lib/client.js:163:19)
2015-09-24T18:31:11.755Z pid:2371 worker:36     at emit (events.js:117:20)
2015-09-24T18:31:11.755Z pid:2371 worker:36     at Socket.<anonymous> (/home/myapp/node_modules/loopback-connector-postgresql/node_modules/pg/lib/connection.js:109:12)

Please notice this is only happening in production having the same modules version as in development:

npm list loopback loopback-datasource-juggler loopback-connector-postgresql
├── [email protected]
├── [email protected]
└── [email protected]

The text was updated successfully, but these errors were encountered:

raymondfeng · 2015-09-24T19:21:41Z

Which version of pg do you have? Can you check if loopback-connector-postgresql/node_modules/pg/lib/pool.js has the release method?

elhoyos · 2015-09-24T19:28:59Z

Running on [email protected]

Here's a strange output:

$ npm list pg
└─┬ [email protected] invalid
  └── [email protected]

And nope, pool.js does not have the mentioned method.

elhoyos · 2015-09-24T19:36:14Z

The package.json of [email protected] says "pg": "^4.2.0" and [email protected] looks valid for me.

elhoyos · 2015-09-24T22:00:15Z

Please ignore the strange "invalid" output. I was doing it from a different project. The one having the TypeError issue looks the same but without the "invalid" string.

bajtos · 2015-10-22T10:49:24Z

@elhoyos could you please create a sample project that we can use to reproduce the problem locally on our machine? See wiki instructions.

timneedham · 2016-04-03T11:48:43Z

Hi,

I think this may be a major issue with the latest loopback-connector-postgres?

loopback-connector:            2.3.0
loopback-connector-postgresql: 2.3.0
loopback-datasource-juggler:   2.45.2
pg:                            4.5.2
generic-pool:                  2.1.1

For me: running >8 concurrent transactions via loopback-connector-postgresql throws TypeError: pool.release is not a function.

As requested, @bajtos: I've created a sample project here with steps to reproduce locally.

@raymondfeng My concern is that under heavy load (using transactions), Loopback will currently fail when using Postgres?

Elindorath · 2016-06-22T08:17:19Z

I can confirm, Loopback is not suitable for production use with Postgres ...

raymondfeng · 2016-06-22T18:42:13Z

See #143

Elindorath · 2016-06-22T19:21:16Z

Glad to hear that! I'll test it as from tomorrow. Thanks a lot for the quick solution!

timneedham · 2016-06-23T10:35:44Z

Great news!

When running more than 9 transactions at the same time, we get an error: "pool.release is not a function". at line 74 inlib/transaction.js. I found out that this.pg is returning an EvenEmitter, containing a pool which contains the function release. Finally, when I call pool.pool.release instead of pool.release, everything works fine and the connection are released on my pg database. This modification fixes the issue loopbackio#109.

robinbiondi · 2016-06-24T08:23:25Z

Hello, It seems that the upgrade of pg was not fixing this issue. Still have the pool.release is not a function.
I made a PR that fixes my issue. PR #146

Fix loopbackio#109 bug transaction concurrency.

Revert "Fix loopbackio#109 bug transaction concurrency."

…io#109-pool-release-fix

#109 pool release fix

* Add test for bulk transactions (Zak Barbuto) * Use pg callback over connection.release (#109) (Zak Barbuto) * Use pool.pool.release over pool.release (#109) (Zak Barbuto) * Add test env information to README (Zak Barbuto) * update README for local postgres setup (Diana Lau) * Update postgresql.js (tmclouisluk) * Fix bug when using postgresql 8.x (tmclouisluk) * Use unique param for affectedRows (Loay) * Move info from docs into README (#199) (Rand McKinney) * Update paid support URL (Siddhi Pai) * Revert loopback 2.x (siddhipai) * Revert dev-dependency on loopback to 2.x (Siddhi Pai) * Set publish tag to "lts" (Siddhi Pai) * Update README with correct doc links, etc (Amir Jafarian)

* Remove console.log (Raymond Feng) * Monkey patch generic-pool to work through errors (Russ Tyndall) * Fix the escape char (Raymond Feng) * Upgrade to [email protected] (Loay) * Add checkFieldAndIndex for table status (#228) (Sakib Hasan) * Refactor migration methods (ssh24) * Fix code style inconsistencies in ilike tests (Alireza Ahmadi) * Improve tests for better code style consistency (Alireza Ahmadi) * Add tests for pattern matching operators (Alireza Ahmadi) * Add ILIKE functionality (Alireza Ahmadi) * Refactor discovery models (Loay Gewily) * merge in #216 (gregdingle) * Fix unit tests (ssh24) * Fix linting errors and unnesssary changes. (Diana Lau) * remove done() calls in test (gregdingle) * Added test. Ran run-tests. (gregdingle) * Fix bug where settings for pg-pool were dropped (Greg Dingle) * Update README with correct doc links, etc (Amir Jafarian) * Add test for bulk transactions (Zak Barbuto) * Use pg callback over connection.release (#109) (Zak Barbuto) * Use pool.pool.release over pool.release (#109) (Zak Barbuto) * Add test env information to README (Zak Barbuto) * update README for local postgres setup (Diana Lau) * Update postgresql.js (tmclouisluk) * Fix bug when using postgresql 8.x (tmclouisluk) * Replicate new issue_template from loopback (Siddhi Pai) * Replicate issue_template from loopback repo (Siddhi Pai) * Update LB connector version (Loay) * Use unique param for affectedRows (Loay) * Move info from docs into README (#199) (Rand McKinney) * Update paid support URL (Siddhi Pai) * Start 3.x + drop support for Node v0.10/v0.12 (siddhipai) * Drop support for Node v0.10 and v0.12 (Siddhi Pai) * Start the development of the next major version (Siddhi Pai)

seanbrookes added the #tob label Sep 28, 2015

bajtos added triaging and removed #tob labels Oct 22, 2015

robinbiondi mentioned this issue Jun 24, 2016

Fix #109 bug transaction concurrency. #146

Closed

robinbiondi added a commit to robinbiondi/loopback-connector-postgresql that referenced this issue Jun 27, 2016

Fix loopbackio#109 bug transaction concurrency.

ed5f009

peterliapin pushed a commit to wavepointcode/loopback-connector-postgresql that referenced this issue Jul 21, 2016

Fix loopbackio#109 bug transaction concurrency

74b925f

rkmax added a commit to bixlabs/loopback-connector-postgresql that referenced this issue Aug 19, 2016

Merge pull request #1 from robinbiondi/patch-1

94f68c8

Fix loopbackio#109 bug transaction concurrency.

rkmax added a commit to bixlabs/loopback-connector-postgresql that referenced this issue Aug 19, 2016

Revert "Fix loopbackio#109 bug transaction concurrency."

e01ce9b

rkmax added a commit to bixlabs/loopback-connector-postgresql that referenced this issue Aug 19, 2016

Merge pull request #2 from bixlabs/revert-1-patch-1

dda0b5f

Revert "Fix loopbackio#109 bug transaction concurrency."

deepakrkris self-assigned this Oct 10, 2016

zbarbuto added a commit to NextFaze/loopback-connector-postgresql that referenced this issue Jan 10, 2017

Merge commit 'f6c06743020d3e88656b0cf62de93df5d16e206f' into loopback…

7201998

…io#109-pool-release-fix

zbarbuto mentioned this issue Jan 10, 2017

#109 pool release fix #196

Closed

1 task

zbarbuto added a commit to zbarbuto/loopback-connector-postgresql that referenced this issue Jan 10, 2017

Use pool.pool.release over pool.release (loopbackio#109)

54d1dc3

zbarbuto added a commit to zbarbuto/loopback-connector-postgresql that referenced this issue Jan 10, 2017

Use pg callback over connection.release (loopbackio#109)

df817ac

zbarbuto mentioned this issue Jan 10, 2017

#109 pool release fix #197

Merged

2 tasks

crandmck added the #community contribution label Jan 10, 2017

cadesalaberry pushed a commit to robinbiondi/loopback-connector-postgresql that referenced this issue Jan 18, 2017

Fix loopbackio#109 bug transaction concurrency.

69fb828

zbarbuto added a commit to zbarbuto/loopback-connector-postgresql that referenced this issue Feb 16, 2017

Use pool.pool.release over pool.release (loopbackio#109)

af9a265

zbarbuto added a commit to zbarbuto/loopback-connector-postgresql that referenced this issue Feb 16, 2017

Use pg callback over connection.release (loopbackio#109)

364dfaa

zbarbuto added a commit to zbarbuto/loopback-connector-postgresql that referenced this issue Feb 17, 2017

Use pool.pool.release over pool.release (loopbackio#109)

d1229ec

zbarbuto added a commit to zbarbuto/loopback-connector-postgresql that referenced this issue Feb 17, 2017

Use pg callback over connection.release (loopbackio#109)

65c8a2d

zbarbuto added a commit to zbarbuto/loopback-connector-postgresql that referenced this issue Feb 21, 2017

Use pool.pool.release over pool.release (loopbackio#109)

4fbf6d1

zbarbuto added a commit to zbarbuto/loopback-connector-postgresql that referenced this issue Feb 21, 2017

Use pg callback over connection.release (loopbackio#109)

3d520e0

jannyHou closed this as completed in #197 Feb 21, 2017

jannyHou pushed a commit that referenced this issue Feb 21, 2017

Merge pull request #197 from zbarbuto/#109-pool-release-fix

679fb05

#109 pool release fix

jannyHou removed the #community contribution label Feb 21, 2017

jannyHou pushed a commit that referenced this issue Feb 24, 2017

Use pool.pool.release over pool.release (#109)

0ae9c45

jannyHou pushed a commit that referenced this issue Feb 24, 2017

Use pg callback over connection.release (#109)

ef5fea8

jannyHou pushed a commit that referenced this issue Feb 24, 2017

Use pool.pool.release over pool.release (#109)

ae9eccd

jannyHou pushed a commit that referenced this issue Feb 24, 2017

Use pg callback over connection.release (#109)

c7fdeb9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

TypeError: Object [object Object] has no method 'release' #109

TypeError: Object [object Object] has no method 'release' #109

elhoyos commented Sep 24, 2015

raymondfeng commented Sep 24, 2015

Uh oh!

elhoyos commented Sep 24, 2015

Uh oh!

elhoyos commented Sep 24, 2015

Uh oh!

elhoyos commented Sep 24, 2015

Uh oh!

bajtos commented Oct 22, 2015

Uh oh!

timneedham commented Apr 3, 2016

Uh oh!

Elindorath commented Jun 22, 2016

Uh oh!

raymondfeng commented Jun 22, 2016

Uh oh!

Elindorath commented Jun 22, 2016 •

edited

Loading

Uh oh!

timneedham commented Jun 23, 2016

Uh oh!

robinbiondi commented Jun 24, 2016 •

edited

Loading

Uh oh!

TypeError: Object [object Object] has no method 'release' #109

TypeError: Object [object Object] has no method 'release' #109

Comments

elhoyos commented Sep 24, 2015

raymondfeng commented Sep 24, 2015

Uh oh!

elhoyos commented Sep 24, 2015

Uh oh!

elhoyos commented Sep 24, 2015

Uh oh!

elhoyos commented Sep 24, 2015

Uh oh!

bajtos commented Oct 22, 2015

Uh oh!

timneedham commented Apr 3, 2016

Uh oh!

Elindorath commented Jun 22, 2016

Uh oh!

raymondfeng commented Jun 22, 2016

Uh oh!

Elindorath commented Jun 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timneedham commented Jun 23, 2016

Uh oh!

robinbiondi commented Jun 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Elindorath commented Jun 22, 2016 •

edited

Loading

robinbiondi commented Jun 24, 2016 •

edited

Loading