Merge pull request #197 from zbarbuto/#109-pool-release-fix

#109 pool release fix

Author: Janny

lib/transaction.js

@@ -21,6 +21,7 @@ function mixinTransaction(PostgreSQL) {
     debug('Begin a transaction with isolation level: %s', isolationLevel);
     this.pg.connect(function(err, connection, done) {
       if (err) return cb(err);
+      connection.autorelease = done;
       connection.query('BEGIN TRANSACTION ISOLATION LEVEL ' + isolationLevel,
         function(err) {
           if (err) return cb(err);
@@ -63,15 +64,15 @@ function mixinTransaction(PostgreSQL) {
   };
 
   PostgreSQL.prototype.releaseConnection = function(connection, err) {
-    if (typeof connection.release === 'function') {
-      connection.release(err);
-      connection.release = null;
+    if (typeof connection.autorelease === 'function') {
+      connection.autorelease(err);
+      connection.autorelease = null;
     } else {
       var pool = this.pg;
       if (err) {
-        pool.destroy(connection);
+        pool.pool.destroy(connection);
       } else {
-        pool.release(connection);
+        pool.pool.release(connection);
       }
     }
   };

test/postgresql.transaction.test.js

@@ -58,6 +58,41 @@ describe('transactions', function() {
     };
   }
 
+  describe('bulk', function() {
+    it('should work with bulk transactions', function(done) {
+      var completed = 0;
+      var concurrent = 20;
+      for (var i = 0; i <= concurrent; i++) {
+        var post = {title: 'tb' + i, content: 'cb' + i};
+        var create = createPostInTx(post);
+        Transaction.begin(db.connector, Transaction.SERIALIZABLE,
+          function(err, tx) {
+            if (err) return done(err);
+            Post.create(post, {transaction: tx},
+              function(err, p) {
+                if (err) {
+                  done(err);
+                } else {
+                  tx.commit(function(err) {
+                    if (err) {
+                      done(err);
+                    }
+                    completed++;
+                    checkResults();
+                  });
+                }
+              });
+          });
+      }
+
+      function checkResults() {
+        if (completed === concurrent) {
+          done();
+        }
+      }
+    });
+  });
+
   describe('commit', function() {
     var post = {title: 't1', content: 'c1'};
     before(createPostInTx(post));