Unsafe

[lavalamp]

Only the last commit is new. These numbers are for just that commit.

benchmark                                 old ns/op     new ns/op     delta
BenchmarkFieldSet/serialize-20-12         27360         15191         -44.48%
BenchmarkFieldSet/deserialize-20-12       35718         35840         +0.34%
BenchmarkFieldSet/serialize-50-12         57494         37869         -34.13%
BenchmarkFieldSet/deserialize-50-12       86494         82157         -5.01%
BenchmarkFieldSet/serialize-100-12        170144        111428        -34.51%
BenchmarkFieldSet/deserialize-100-12      223283        224378        +0.49%
BenchmarkFieldSet/serialize-500-12        919350        597742        -34.98%
BenchmarkFieldSet/deserialize-500-12      1084716       1062631       -2.04%
BenchmarkFieldSet/serialize-1000-12       1786525       1167377       -34.66%
BenchmarkFieldSet/deserialize-1000-12     1950813       2292026       +17.49%

benchmark                                 old allocs     new allocs     delta
BenchmarkFieldSet/serialize-20-12         110            25             -77.27%
BenchmarkFieldSet/deserialize-20-12       216            216            +0.00%
BenchmarkFieldSet/serialize-50-12         300            50             -83.33%
BenchmarkFieldSet/deserialize-50-12       616            614            -0.32%
BenchmarkFieldSet/serialize-100-12        1032           95             -90.79%
BenchmarkFieldSet/deserialize-100-12      2167           2166           -0.05%
BenchmarkFieldSet/serialize-500-12        5701           472            -91.72%
BenchmarkFieldSet/deserialize-500-12      10770          10779          +0.08%
BenchmarkFieldSet/serialize-1000-12       12365          1000           -91.91%
BenchmarkFieldSet/deserialize-1000-12     23523          23534          +0.05%

Unfortunately I don't think I can give deserialize the same treatment without making jsoniter changes :/

Note that this makes use of the unsafe package, I need changes to jsoniter to avoid that.

Jsoniter's pools are apparently... not for the purpose of doing optimal memory management.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lavalamp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lavalamp]

This brings the total improvement to:

benchmark                       old ns/op     new ns/op     delta
BenchmarkApplyNewObject-12      2230683       1933055       -13.34%
BenchmarkUpdateNewObject-12     2624417       2236517       -14.78%
BenchmarkRepeatedUpdate-12      1031653       755754        -26.74%
BenchmarkSetToFields-12         24778         5078          -79.51%
BenchmarkFieldsToSet-12         33876         10309         -69.57%
BenchmarkYAMLToTyped-12         68377         65714         -3.89%

benchmark                       old allocs     new allocs     delta
BenchmarkApplyNewObject-12      8632           6827           -20.91%
BenchmarkUpdateNewObject-12     11210          7913           -29.41%
BenchmarkRepeatedUpdate-12      3057           2288           -25.16%
BenchmarkSetToFields-12         124            15             -87.90%
BenchmarkFieldsToSet-12         147            82             -44.22%
BenchmarkYAMLToTyped-12         150            152            +1.33%

[lavalamp]

The unsafe bit is key, sadly-- removing it I get

benchmark                                 old allocs     new allocs     delta
BenchmarkFieldSet/serialize-20-12         25             96             +284.00%
BenchmarkFieldSet/deserialize-20-12       216            216            +0.00%
BenchmarkFieldSet/serialize-50-12         50             254            +408.00%
BenchmarkFieldSet/deserialize-50-12       614            616            +0.33%
BenchmarkFieldSet/serialize-100-12        95             803            +745.26%
BenchmarkFieldSet/deserialize-100-12      2166           2168           +0.09%
BenchmarkFieldSet/serialize-500-12        472            4013           +750.21%
BenchmarkFieldSet/deserialize-500-12      10779          10773          -0.06%
BenchmarkFieldSet/serialize-1000-12       1000           8654           +765.40%
BenchmarkFieldSet/deserialize-1000-12     23534          23511          -0.10%

[lavalamp]

json-iterator/go#393

[lavalamp]

I've modified this to do a less unsafe thing with the unsafe package. (performance is the same.)

[apelisse]

I think this is OK. I don't have much knowledge about jsoniter though.

[apelisse]

/lgtm

Should we rebase before merging?
/hold

[apelisse]

/lgtm
/hold cancel

[lavalamp]

rebased, but I see you already noticed... :)