Skip to content

add WriteBytesAsString() #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lavalamp
Copy link

I have a situation where I'm constructing key names, and I want to avoid an allocation; I can do this cast in my code, but I thought I'd see if there's interest in accepting this so it's obvious for other people how to do this?

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #393 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #393      +/-   ##
=========================================
- Coverage   81.81%   81.7%   -0.12%     
=========================================
  Files          41      41              
  Lines        5022    5024       +2     
=========================================
- Hits         4109    4105       -4     
- Misses        792     798       +6     
  Partials      121     121
Impacted Files Coverage Δ
reflect_struct_encoder.go 88.98% <100%> (ø) ⬆️
stream_str.go 94.17% <100%> (+0.11%) ⬆️
reflect_struct_decoder.go 48.32% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27518f6...41a54ea. Read the comment docs.

@taowen
Copy link
Contributor

taowen commented Sep 23, 2019

I prefer to keep the casting in user code.

@taowen taowen closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants