Make a clone of k8s master instead of using archive #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/release-note none |
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
/assign @saikat-royc |
saikat-royc
reviewed
Mar 15, 2021
| vKubeVersion = kubeVersion | ||
| // A hack to be able to build Kubernetes in this nested place | ||
| // KUBE_GIT_VERSION_FILE set to file to load kube version from | ||
| err = os.Setenv("KUBE_GIT_VERSION_FILE", filepath.Join(pkgDir, "test", "k8s-integration", ".dockerized-kube-version-defs")) |
There was a problem hiding this comment.
Should we also remove dockerized-kube-version-defs file if its not needed now?
There was a problem hiding this comment.
I did remove it :-)
|
the change looks good to me, with some minor comment |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
Which issue(s) this PR fixes:
Fixes #721
Special notes for your reviewer:
This is a more complete change compare with #722.
See the comment in the change for the details of how the git clone is done for the master branch.
Pulling a specific version is unchanged (the k/k release archive is still used).
Does this PR introduce a user-facing change?: