Skip to content

Set major & minor version in docker version defs #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mattcary
Copy link
Contributor

This should get kube-up used by the integration tests temporarily working. It appears the old fake 888.888 version was causing something---I haven't figured out what yet---to not get installed or activated, and node RBAC couldn't get installed. See the issue for further details.

/kind bug

Which issue(s) this PR fixes:
Fixes #721

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2021
@k8s-ci-robot k8s-ci-robot requested a review from davidz627 March 14, 2021 06:51
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from jingxu97 March 14, 2021 06:51
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2021
@mattcary
Copy link
Contributor Author

/assign @saikat-royc

@mattcary
Copy link
Contributor Author

See #723 for an alternative fix. This one can be pushed quickly to stop the current bleeding.

@mattcary
Copy link
Contributor Author

/assign @saikat-royc

@mattcary
Copy link
Contributor Author

Obsolete by #723
/close

@k8s-ci-robot
Copy link
Contributor

@mattcary: Closed this PR.

In response to this:

Obsolete by #723
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2021
@k8s-ci-robot
Copy link
Contributor

@mattcary: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mattcary mattcary deleted the version branch November 11, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCE cluster up is failing for k8s-integration tests on k/k master.
3 participants