Add gce disk labels support via create volume parameters #718
Conversation
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| metadata: | ||
| name: csi-gce-pd | ||
| provisioner: pd.csi.storage.gke.io | ||
| parameters: |
There was a problem hiding this comment.
We should put a comment somewhere, about which overlay build would honor this label?
pkg/common/parameters_test.go
Outdated
| }, | ||
| }, | ||
| { | ||
| name: "random keys", | ||
| parameters: map[string]string{ParameterKeyType: "", "foo": "", ParameterKeyDiskEncryptionKmsKey: ""}, | ||
| parameters: map[string]string{ParameterKeyType: "", "foo": "", ParameterKeyDiskEncryptionKmsKey: "", ParameterKeyLabels: ""}, | ||
| labels: map[string]string{}, | ||
| expectErr: true, | ||
| }, | ||
| { | ||
| name: "real values", |
There was a problem hiding this comment.
maybe we should elaborate the tc name, as labels picked from params
| return labelsMap, nil | ||
| } | ||
|
|
||
| regexKey, _ := regexp.Compile(`^\p{Ll}[\p{Ll}0-9_-]{0,62}$`) |
There was a problem hiding this comment.
Maybe we can put a pointer to the label format https://cloud.google.com/compute/docs/labeling-resources#label_format
|
overall the changes look good to me, with some minor nits. |
k8s-ci-robot
added
the
needs-rebase
Add labels validation to match gce requirements add e2e test case for labels
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Labels are validated to match gce requirements.
Cherry-picked from #566
Which issue(s) this PR fixes:
Fixes #340