Remove Probe logging #682
Merged
Remove Probe logging #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is especially useful when we have a livenessprobe sidecar The log can be spamed with all the probe logs if we record them
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
cncf-cla: yes
|
/cc @msau42 |
|
It would be so much easier to debug and log searching with this PR merged. |
|
This seems reasonable to me, but maybe I'm missing something. @msau42 wdyt? |
|
I would strongly suggest we merge this PR to save the log space from GKE point of view. Otherwise the pd driver log will be spammed with the probe logging |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jiawei0227, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially useful when we have a livenessprobe sidecar
The log can be spamed with all the probe logs if we record them
What type of PR is this?
What this PR does / why we need it:
This PR removes probe logging for pd driver. Since it can provide huge noise to the entire logging if we enable livenessprobe
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: