Wait for windows prepull images rather than sleeping #624
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
|
/assign @jingxu97 |
| # Wait up to 15 minutes for the test images to be pulled onto the nodes. | ||
| retries=90 | ||
| while [[ $retries -ge 0 ]];do | ||
| ready=$(kubectl get daemonset "${prepull_daemonset}" -o jsonpath="{.status.numberReady}") |
There was a problem hiding this comment.
this logic is similar to the other wait script, maybe we can consolidate to a common function later?
There was a problem hiding this comment.
I think we should probably move to client-go and have it in code. That's a bigger change than I want to do right now though.
Consolidating would mean have a shared bash include directory between deploy/kubernetes and test/k8s-integration which starts to get messy.
There was a problem hiding this comment.
#625 created for the client-go work.
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug
Which issue(s) this PR fixes:
Fixes #614