Skip to content

Add pod wait function in k8s integration test, for pd driver start and also prepull image daemonset #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jingxu97 opened this issue Sep 24, 2020 · 7 comments · Fixed by #620 or #624
Assignees

Comments

@jingxu97
Copy link
Contributor

See comments here #613 (comment)

Currently workflow, it waits for certain of of time for prepull calls driver or pr pd csi driver part.

@mattcary
Copy link
Contributor

/assign

I have a PR ready that's waiting on the ADC one (https://github.com/mattcary/gcp-compute-persistent-disk-csi-driver/tree/wait)

It conflicts with the ADC change so it was complicated to send it out for review.

@mattcary
Copy link
Contributor

mattcary commented Oct 2, 2020

/open

@jingxu97 do we need to do something for the "prepull image daemonset"? We wait on the daemonset deployment, I'm not sure what you mean buy "prepull"

@jingxu97
Copy link
Contributor Author

jingxu97 commented Oct 2, 2020

@mattcary prepull script is starting a daemonSet with specific container image. The purpose is to download image by running those containers. We want to do this before running tests so that all the images are already local when tests start to run. Otherwise, it will definitely exceed 5 mins timeout for pods to start which is coded in the tests.

Yes, we should use your wait script to wait for those daemonSet and then delete them

@jingxu97
Copy link
Contributor Author

jingxu97 commented Oct 7, 2020

somehow it cannot be reopened?

@mattcary
Copy link
Contributor

mattcary commented Oct 7, 2020

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Oct 7, 2020
@k8s-ci-robot
Copy link
Contributor

@mattcary: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mattcary
Copy link
Contributor

mattcary commented Oct 7, 2020

There we go :-)

I just sent a PR for the daemonset issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants