Skip to content

add functionality to use gke with kubetest #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2019
Merged

add functionality to use gke with kubetest #358

merged 1 commit into from
Jul 31, 2019

Conversation

hantaowang
Copy link

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Our new testing framework kubetest does not work out of the box with GKE.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
/assign @davidz627 @jingxu97

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 29, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2019
@hantaowang hantaowang force-pushed the kube-test-with-gke branch from 3df999a to 80c62dc Compare July 29, 2019 22:14
@hantaowang hantaowang mentioned this pull request Jul 29, 2019
Closed
davidz627
davidz627 reviewed Jul 30, 2019
View reviewed changes
test/k8s-integration/cluster.go Outdated

func getGKEKubeTestArgs() ([]string, error) {
gkeEnv := "prod"
if len(os.Getenv("CLOUDSDK_API_ENDPOINT_OVERRIDES_CONTAINER")) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the override value could possibly be "test", "staging2", "dev" as well? Could we do a lookup env and parse out the actual environment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from https://github.com/kubernetes/test-infra/blob/6f786f4306700573630e4698e8f73d7db0baaa01/kubetest/gke.go#L194 it cant be dev or staging2. I've changed it to a switch statement.

@hantaowang hantaowang force-pushed the kube-test-with-gke branch 2 times, most recently from 45a89c4 to 3c33b1f Compare July 30, 2019 21:52
@hantaowang hantaowang force-pushed the kube-test-with-gke branch from 3c33b1f to ef9bfb2 Compare July 30, 2019 23:03
@davidz627
Copy link
Contributor

/lgtm
/retest
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, hantaowang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit c782884 into kubernetes-sigs:master Jul 31, 2019
@hantaowang hantaowang mentioned this pull request Aug 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 davidz627 left review comments

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@davidz627 davidz627

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hantaowang @davidz627 @k8s-ci-robot @jingxu97