Skip to content

build kubectl for test kube directory #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build kubectl for test kube directory #352

wants to merge 1 commit into from

Conversation

hantaowang
Copy link

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Builds k8s testing src with make quick release so that kubetest has access to the kubectl built.

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 22, 2019
@k8s-ci-robot k8s-ci-robot requested review from davidz627 and verult July 22, 2019 21:00
@hantaowang
Copy link
Author

/assign @davidz627

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 22, 2019
davidz627
davidz627 reviewed Jul 22, 2019
View reviewed changes
test/k8s-integration/main.go Outdated
@@ -212,7 +212,7 @@ func handle() error {
if err != nil {
return fmt.Errorf("failed to download Kubernetes source: %v", err)
}
err = buildKubernetes(testDir, "WHAT=test/e2e/e2e.test")
err = buildKubernetes(testDir, "quick-release")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a "TODO" to parallelize these builds since they'll take a long time now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this, it may not make sense to parallelize k8s builds because each quick-release is already parallelized you can check htop to confirm). You might save some time on the go builds for certain components that are not, but then suffer from the context switching.

This is also why my desktop was dying earlier - I was parallelizing two builds.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the PR so it builds kubectl specificlly (I figured out how). Currently testing to see if this solves it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping me when ready for review

@hantaowang hantaowang force-pushed the make-quick-release-for-test branch from 236516e to 85cfcf3 Compare July 23, 2019 01:39
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hantaowang
To complete the pull request process, please assign davidz627
You can assign the PR to them by writing /assign @davidz627 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hantaowang hantaowang changed the title make quick-release for test kube too build kubectl for test kube directory Jul 23, 2019
@hantaowang hantaowang force-pushed the make-quick-release-for-test branch from 85cfcf3 to d3e1d43 Compare July 23, 2019 01:44
@hantaowang
Copy link
Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2019
@hantaowang hantaowang force-pushed the make-quick-release-for-test branch from d3e1d43 to 5732407 Compare July 24, 2019 02:15
@hantaowang hantaowang force-pushed the make-quick-release-for-test branch from 5732407 to 5120d31 Compare July 24, 2019 02:17
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2019
@k8s-ci-robot
Copy link
Contributor

@hantaowang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration 5120d31 link /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hantaowang
Copy link
Author

/close
Use #358 instead

@k8s-ci-robot
Copy link
Contributor

@hantaowang: Closed this PR.

In response to this:

/close
Use #358 instead

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hantaowang hantaowang mentioned this pull request Aug 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 davidz627 left review comments

@verult verult Awaiting requested review from verult

Assignees

@davidz627 davidz627

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hantaowang @k8s-ci-robot @davidz627