Skip to content

Added Boskos project lending for E2E test AND prune non-go files from deps #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 28, 2018
Merged

Added Boskos project lending for E2E test AND prune non-go files from deps #23

merged 4 commits into from
Jun 28, 2018

Conversation

davidz627
Copy link
Contributor

Fixes: #21

If project is not set, attempt to loan a Boskos project. This should be used on CI.

/assign @msau42 @krzyzacy

@davidz627 davidz627 added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 25, 2018
@k8s-ci-robot
Copy link
Contributor

@davidz627: GitHub didn't allow me to assign the following users: krzyzacy.

Note that only kubernetes-sigs members and repo collaborators can be assigned.

In response to this:

Fixes: #21

If project is not set, attempt to loan a Boskos project. This should be used on CI.

/assign @msau42 @krzyzacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from saad-ali June 25, 2018 19:40
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2018
krzyzacy
krzyzacy reviewed Jun 25, 2018
View reviewed changes
test/remote/run_remote/run_remote.go Outdated
@@ -30,6 +30,7 @@ import (
"github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/test/remote/remote"
"k8s.io/apimachinery/pkg/util/uuid"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/test-infra/boskos/client"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor the library?

@krzyzacy
Copy link

@rmmh the gubernator link is wrong... I think because we mucked with sigs.k8s.io and kubernetes-sigs?

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2018
@davidz627
Copy link
Contributor Author

I see that other repos use sigs.k8s.io. I didn't realize that was the convention so maybe I should change mine as well.

@davidz627
Copy link
Contributor Author

/retest

@davidz627 davidz627 force-pushed the feature/BoskosLoan branch 10 times, most recently from 3762346 to 4760fcb Compare June 28, 2018 00:22
krzyzacy
krzyzacy reviewed Jun 28, 2018
View reviewed changes
Gopkg.toml Outdated
@@ -78,3 +78,6 @@
branch = "master"
name = "github.com/kubernetes-csi/csi-test"

[[constraint]]
branch = "master"
name = "k8s.io/test-infra"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hummm I think you don't need the entire test-infra repo...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I saw you only included three packages, wonder why it tries to pull in stuff like triage and gubernator, maybe a good question for @ixdy)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix soon,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get dep to play nice. According to docs it needs to pull in the entire package from the root -_-

@davidz627 davidz627 force-pushed the feature/BoskosLoan branch 2 times, most recently from 96e2ed2 to 21b5700 Compare June 28, 2018 00:27
@davidz627 davidz627 changed the title Added Boskos project lending for E2E test [WIP] Added Boskos project lending for E2E test Jun 28, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2018
@davidz627 davidz627 force-pushed the feature/BoskosLoan branch from 21b5700 to f16bb47 Compare June 28, 2018 00:32
@davidz627 davidz627 force-pushed the feature/BoskosLoan branch 5 times, most recently from 33fc4fc to 2940fa0 Compare June 28, 2018 01:19
@davidz627 davidz627 force-pushed the feature/BoskosLoan branch from 2940fa0 to 346762e Compare June 28, 2018 17:56
@davidz627 davidz627 changed the title [WIP] Added Boskos project lending for E2E test Added Boskos project lending for E2E test Jun 28, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2018
@davidz627
Copy link
Contributor Author

/retest

@davidz627
Copy link
Contributor Author

@krzyzacy @msau42 This PR is now working and ready for review 👍

@krzyzacy
Copy link

hummm @ixdy so all the license files are pulled in intentionally?

krzyzacy
krzyzacy reviewed Jun 28, 2018
View reviewed changes
test/remote/run_remote/run_remote.go
@@ -103,8 +108,56 @@ func main() {
flag.Parse()
suite = remote.InitE2ERemote()

if *serviceAccount == "" {
glog.Fatal("You must specify a service account to create an instance under that has at least OWNERS permissions on disks and READER on instances.")
if *runInProw {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hummm why not just check if project is empty?

Copy link
Contributor Author

@davidz627 davidz627 Jun 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather there be a special flag for running in prow since there's a lot of special set-up involved. If the project is empty and runInProw is not set then the user gets a nice reasonable error to set the project instead of something that mentions Boskos and other things they dont need to know about

@ixdy
Copy link

ixdy commented Jun 28, 2018

You might want to add non-go = true to the [prune] section of your Gopkg.toml. (See https://golang.github.io/dep/docs/Gopkg.toml.html#prune for more details)

@davidz627 davidz627 changed the title Added Boskos project lending for E2E test Added Boskos project lending for E2E test AND prune non-go files from deps Jun 28, 2018
@msau42
Copy link
Contributor

msau42 commented Jun 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit ef6b6e3 into kubernetes-sigs:master Jun 28, 2018
@davidz627 davidz627 deleted the feature/BoskosLoan branch June 28, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidz627 @k8s-ci-robot @krzyzacy @ixdy @msau42