Testing commit

Author: davidz627

test/remote/run_remote/run_remote.go

@@ -24,6 +24,7 @@ import (
 	"math/rand"
 	"net/http"
 	"os"
+	"os/exec"
 	"strings"
 	"sync"
 	"time"
@@ -110,7 +111,9 @@ func main() {
 		glog.Fatal("You must specify a service account to create an instance under that has at least OWNERS permissions on disks and READER on instances.")
 	}
 
-	if *project == "" {
+	// TODO: OVERWRITE PROJECT FOR TEST PURPOSES ONLY
+	if true /* *project == "" */ {
+		// TODO: Check if we're on CI and just overwrite project anyway if we are.
 		// Try get a Boskos Project
 		glog.Infof("--project is missing, trying to fetch a project from boskos.\n" +
 			"(for local runs please set --project to your dev project)")
@@ -126,6 +129,8 @@ func main() {
 
 		*project = p.GetName()
 
+		glog.Infof("Fetched project from Boskos: %v", *project)
+
 		go func(c *client.Client, proj string) {
 			for range time.Tick(time.Minute * 5) {
 				if err := c.UpdateOne(p.Name, "busy", nil); err != nil {
@@ -300,7 +305,7 @@ func createInstance(serviceAccount string) (string, error) {
 	myuuid := string(uuid.NewUUID())
 	glog.V(2).Infof("Creating instance: %v", name)
 
-	imageURL := "https://www.googleapis.com/compute/v1/projects/ml-images/global/images/debian-9-tf-1-9-v20180626"
+	imageURL := "projects/ml-images/global/images/family/tf-1-9"
 	i := &compute.Instance{
 		Name:        name,
 		MachineType: machineType(""),
@@ -326,18 +331,33 @@ func createInstance(serviceAccount string) (string, error) {
 		},
 	}
 
-	if serviceAccount != "" {
-		saObj := &compute.ServiceAccount{
-			Email:  serviceAccount,
-			Scopes: []string{"https://www.googleapis.com/auth/cloud-platform"},
+	// TODO: OVERWRITE SERVICEACCOUNT FOR TEST PURPOSES ONLY
+	if true /* serviceAccount == "" */ {
+		// TODO: Check if on CI
+		// Assume we are on CI and grab service account from gcloud
+		glog.Infof("Running on CI, getting gcloud account")
+		cmd := exec.Command("gcloud", "config", "get-value", "account")
+		out, err := cmd.Output()
+
+		if err != nil {
+			return "", fmt.Errorf("Failed to get current gclou account: %v", err)
 		}
-		i.ServiceAccounts = []*compute.ServiceAccount{saObj}
+
+		serviceAccount = string(out)
+		glog.Infof("Got service account: %v", serviceAccount)
+
 	}
 
+	saObj := &compute.ServiceAccount{
+		Email:  serviceAccount,
+		Scopes: []string{"https://www.googleapis.com/auth/compute"},
+	}
+	//i.ServiceAccounts = []*compute.ServiceAccount{saObj}
+
 	var err error
 	if gotInstance, err := computeService.Instances.Get(*project, *zone, i.Name).Do(); err != nil {
 		op, err := computeService.Instances.Insert(*project, *zone, i).Do()
-		glog.V(4).Infof("Inserted instance in project %v, zone %v: %#v", *project, *zone, i)
+		glog.Infof("Inserted instance in project %v, zone %v: %#v", *project, *zone, i)
 		if err != nil {
 			ret := fmt.Sprintf("could not create instance %s: API error: %v", name, err)
 			if op != nil {
@@ -347,21 +367,37 @@ func createInstance(serviceAccount string) (string, error) {
 		} else if op.Error != nil {
 			return "", fmt.Errorf("could not create instance %s: %+v", name, op.Error)
 		}
+
+		// WAIT FOR OP
+		wait.Poll(3*time.Second, 5*time.Minute, func() (bool, error) {
+			pollOp, err := computeService.ZoneOperations.Get(*project, *zone, op.Name).Do()
+			if err != nil {
+				glog.Errorf("WaitForOp(op: %#v, zone: %#v) failed to poll the operation: %v", op, zone, err)
+				return false, err
+			}
+			glog.Infof("Insert Op data: %#v", pollOp)
+			glog.Infof("Op Error: %v", pollOp.Error)
+			done := opIsDone(pollOp)
+			return done, err
+		})
+
 	} else {
-		glog.V(4).Infof("Compute service GOT instance %v, skipping instance creation: %#v", i.Name, gotInstance)
+		glog.Infof("Compute service GOT instance %v, skipping instance creation: %#v", i.Name, gotInstance)
 	}
 
-	pubkey, ok := os.LookupEnv("JENKINS_GCE_SSH_PUBLIC_KEY_FILE")
-	if ok {
-		glog.Infof("Running on Jenkins and JENKINS_GCE_SSH_PUBLIC_KEY_FILE set")
-		// If we're on CI add public SSH keys to the instance
-		err = addPubKeyToInstance(*project, *zone, i.Name, pubkey)
-		if err != nil {
-			return "", fmt.Errorf("could not add Jenkins public key %v to instance %v: %v", pubkey, i.Name, err)
+	/*
+		pubkey, ok := os.LookupEnv("JENKINS_GCE_SSH_PUBLIC_KEY_FILE")
+		if ok {
+			glog.Infof("Running on Jenkins and JENKINS_GCE_SSH_PUBLIC_KEY_FILE set")
+			// If we're on CI add public SSH keys to the instance
+			err = addPubKeyToInstance(*project, *zone, i.Name, pubkey)
+			if err != nil {
+				return "", fmt.Errorf("could not add Jenkins public key %v to instance %v: %v", pubkey, i.Name, err)
+			}
+		} else {
+			glog.Infof("JENKINS_GCE_SSH_PUBLIC_KEY_FILE not set, not adding SSH public key to instance")
 		}
-	} else {
-		glog.V(4).Infof("JENKINS_GCE_SSH_PUBLIC_KEY_FILE not set, not adding SSH public key to instance")
-	}
+	*/
 
 	then := time.Now()
 	err = wait.Poll(10*time.Second, 5*time.Minute, func() (bool, error) {
@@ -521,3 +557,7 @@ func testsToGinkgoFocus(tests []string) string {
 	}
 	return focus + "\""
 }
+
+func opIsDone(op *compute.Operation) bool {
+	return op != nil && op.Status == "DONE"
+}