Strip secret fields from GRPC loggin #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
davidz627
force-pushed
the
feature/csiLib
branch
from
07be090 to
ffb03d7
Compare
msau42
reviewed
Mar 8, 2019
| @@ -49,12 +50,12 @@ func NewNodeServiceCapability(cap csi.NodeServiceCapability_RPC_Type) *csi.NodeS | |||
|
|
|||
| func logGRPC(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) { | |||
There was a problem hiding this comment.
i think there's actually a logGRPC function under csi-lib-utils/rpc if you want
There was a problem hiding this comment.
discussed offline, it is the client side version. since pd driver is server side we have to use a different logGRPC
davidz627
force-pushed
the
feature/csiLib
branch
from
ffb03d7 to
75257e8
Compare
k8s-ci-robot
added
size/XXL
davidz627
force-pushed
the
feature/csiLib
branch
from
75257e8 to
0c2fcee
Compare
k8s-ci-robot
added
size/XL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCE PD Driver does not use secret fields, but this is cheap and will strip secret fields from logs in case they are accidentally passed to the driver.
Fixes: #180
/assign @msau42 @saad-ali