Skip to content

[IMPORTANT] Take advantage of csi_secret in CSI 1.0 #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saad-ali opened this issue Nov 18, 2018 · 1 comment
Closed

[IMPORTANT] Take advantage of csi_secret in CSI 1.0 #180

saad-ali opened this issue Nov 18, 2018 · 1 comment
Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@saad-ali
Copy link
Contributor

saad-ali commented Nov 18, 2018 •
edited
Loading

CSI 1.0 decorates sensitive fields with csi_secret. Let's take advantage of this feature to programmatically ensure no sensitive fields are ever logged by this driver.
@davidz627 davidz627 added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 26, 2018
@davidz627 davidz627 changed the title Take advantage of csi_secret in CSI 1.0 [IMPORTANT] Take advantage of csi_secret in CSI 1.0 Nov 26, 2018
@davidz627
Copy link
Contributor

Marking this as high priority so that we dont have security issues. GCE PD doesn't actually accept any secrets but if a user mistakenly sends them in, we still don't want to log them

@davidz627 davidz627 mentioned this issue Mar 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidz627 @saad-ali