Reassign error returned from validateStoragePools so InvalidArgument is recorded

[amacaskill]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Reassign error returned from validateStoragePools so InvalidArgument is recorded. Currently, since the error is not reassigned to have the InvalidArgumentCode, when defer gceCS.Metrics.RecordOperationErrorMetrics("CreateVolume", err, diskTypeForMetric, enableConfidentialCompute, enableStoragePools) is executed, it passes an error that looks like fmt.Errorf("error") to RecordOperationErrorMetrics, which is technically an Internal error.

I'm fixing this first for Storage Pools, but it looks like we have this issue in a lot of places. In some cases, we don't reassign the error at all, meaning defer gceCS.Metrics.RecordOperationErrorMetrics("CreateVolume", err, diskTypeForMetric, enableConfidentialCompute, enableStoragePools) will actually pass a nil error, resulting in a OK status CreateVolume call being reported to the operation error metric. In some places (like in the Storage Pools case), we reassign the err, but we add an error code onto the error before returning. This won't get recorded to RecordOperationErrorMetrics unless we actually reassign this error, or implement RecordOperationErrorMetrics in a different way.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Reassign error returned from validateStoragePools so InvalidArgument is recorded

[amacaskill]

/assign @mattcary

[mattcary]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [amacaskill,mattcary]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[amacaskill]

/retest

[amacaskill]

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

[amacaskill]

/easycla

[amacaskill]

/cherry-pick release-1.13

[k8s-infra-cherrypick-robot]

@amacaskill: new pull request created: #1721

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.