reassign error returned from validateStoragePools so InvalidArgument error code is recorded instead of internal error code

amacaskill · amacaskill · commit 8aec1f5c8586 · 2024-05-15T21:36:59.000Z
diff --git a/pkg/gce-pd-csi-driver/controller.go b/pkg/gce-pd-csi-driver/controller.go
@@ -326,7 +326,9 @@ func (gceCS *GCEControllerServer) CreateVolume(ctx context.Context, req *csi.Cre
 
 	err = validateStoragePools(req, params, gceCS.CloudProvider.GetDefaultProject())
 	if err != nil {
-		return nil, status.Errorf(codes.InvalidArgument, "CreateVolume failed to validate storage pools: %v", err)
+		// Reassign error so that all errors are reported as InvalidArgument to RecordOperationErrorMetrics.
+		err = status.Errorf(codes.InvalidArgument, "CreateVolume failed to validate storage pools: %v", err)
+		return nil, err
 	}
 
 	// Verify that the regional availability class is only used on regional disks.

Original file line number	Diff line number	Diff line change
`@@ -326,7 +326,9 @@ func (gceCS GCEControllerServer) CreateVolume(ctx context.Context, req csi.Cre`
`326`	`326`
`327`	`327`	`err = validateStoragePools(req, params, gceCS.CloudProvider.GetDefaultProject())`
`328`	`328`	`if err != nil {`
`329`		`- return nil, status.Errorf(codes.InvalidArgument, "CreateVolume failed to validate storage pools: %v", err)`
	`329`	`+ // Reassign error so that all errors are reported as InvalidArgument to RecordOperationErrorMetrics.`
	`330`	`+ err = status.Errorf(codes.InvalidArgument, "CreateVolume failed to validate storage pools: %v", err)`
	`331`	`+ return nil, err`
`330`	`332`	`}`
`331`	`333`
`332`	`334`	`// Verify that the regional availability class is only used on regional disks.`