Skip to content

Remove device disable call #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

mattcary
Copy link
Contributor

/kind bug

What this PR does / why we need it:
The device disable call has been failing because a newline needed to be added to the "offline" state written to sysfs. But in testing that, we've discovered disabling devices can cause problems. From a comment that I've added into this PR:

Once a device is disabled, it's unusable, and can't be enabled unless the serial number is known. But the serial number cannot be read from the device as it's disabled. If a device is disabled in NodeUnstage, and then NodeStage is called without a NodeUnpublish & publish sequence, the disabled state of the device will cause NodeStage to fail. So this can only be used if we track the serial numbers of disabled devices in a persisent way that survives driver restarts.

Remove disable device call on node unstage. This call was producing spurious error messages and was not effective.

@pwschuurman

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2024
@k8s-ci-robot k8s-ci-robot requested review from leiyiz and tyuchn April 24, 2024 18:27
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@mattcary
Copy link
Contributor Author

/retest

@pwschuurman
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mattcary,pwschuurman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattcary
Copy link
Contributor Author

/retest

@mattcary
Copy link
Contributor Author

mattcary commented May 1, 2024

/retest

I up'd the timeout on the e2e tests, let's see if that fixed it.

@k8s-ci-robot k8s-ci-robot merged commit 17e261e into kubernetes-sigs:master May 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants