-
Notifications
You must be signed in to change notification settings - Fork 159
Add newline character when writing offline to block device state #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newline character when writing offline to block device state #1659
Conversation
/retest |
1 similar comment
/retest |
Nice find! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@pwschuurman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing. We decided to remove the disable device logic in #1689 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR adds "\n" character to the disable device command (when writing to
/sys/block/<devX>/device/state
). Currently the command emitsinvalid argument
(but the error is ignored).Which issue(s) this PR fixes:
Fixes #1146
Special notes for your reviewer:
Without this fix, the
prog.out
in e2e test prints out:Validated that with this fix, this warning is not printed.
Does this PR introduce a user-facing change?: