Skip to content

Automated cherry pick of #1586: update driver to support staging compute #1609: fix pointer issue for GCE staging support #1620: Update to handle when no compute endpoint is passed #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Automated cherry pick of #1586: update driver to support staging compute #1609: fix pointer issue for GCE staging support #1620: Update to handle when no compute endpoint is passed #1653

wants to merge 1 commit into from

Conversation

Sneha-at
Copy link
Contributor

@Sneha-at Sneha-at commented Mar 28, 2024 •
edited
Loading

Cherry pick of #1586 #1609 #1620 on release-1.12.

#1586: update driver to support staging compute
#1609: fix pointer issue for GCE staging support
#1620: Update to handle when no compute endpoint is passed

For details on the cherry pick process, see the cherry pick requests page.

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sneha-at
Once this PR has been reviewed and has the lgtm label, please assign mattcary for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from leiyiz and mattcary March 28, 2024 18:59
@Sneha-at Sneha-at force-pushed the automated-cherry-pick-of-#1586-#1609-#1620-upstream-release-1.12 branch from 382eddb to a2f75c5 Compare March 28, 2024 19:04
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 28, 2024
@Sneha-at
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@Sneha-at Sneha-at marked this pull request as draft March 28, 2024 19:27
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@Sneha-at
Copy link
Contributor Author

/hold need backport approval

@Sneha-at
Copy link
Contributor Author

Sneha-at commented Jun 7, 2024

Duplicate PR #1652

@Sneha-at Sneha-at closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiyiz leiyiz Awaiting requested review from leiyiz

@mattcary mattcary Awaiting requested review from mattcary

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sneha-at @k8s-ci-robot