Skip to content

Fix error when no compute endpoint is passed #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fix error when no compute endpoint is passed #1620

merged 1 commit into from
Feb 23, 2024

Conversation

Sneha-at
Copy link
Contributor

@Sneha-at Sneha-at commented Feb 22, 2024 •
edited by amacaskill
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Fixes the driver error for empty compute endpoint string from #1586
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 22, 2024
@Sneha-at Sneha-at marked this pull request as draft February 22, 2024 23:09
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2024
@Sneha-at
Copy link
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@Sneha-at
Copy link
Contributor Author

/test all

@Sneha-at Sneha-at changed the title Update to handle when no compute endpoint is passed Fix error when no compute endpoint is passed Feb 22, 2024
@Sneha-at Sneha-at force-pushed the add_staging_support branch from c822096 to 6a01a7c Compare February 22, 2024 23:59
@Sneha-at
Copy link
Contributor Author

/test all

@Sneha-at Sneha-at marked this pull request as ready for review February 23, 2024 15:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2024
@Sneha-at
Copy link
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

pwschuurman
pwschuurman reviewed Feb 23, 2024
View reviewed changes
@Sneha-at Sneha-at force-pushed the add_staging_support branch from 6a01a7c to 2bf0478 Compare February 23, 2024 16:16
@pwschuurman
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2024
@Sneha-at
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2024
@Sneha-at Sneha-at force-pushed the add_staging_support branch from 2bf0478 to 7358870 Compare February 23, 2024 18:18
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2024
@Sneha-at
Copy link
Contributor Author

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2024
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2024
@Sneha-at
Copy link
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

@amacaskill
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2024
@amacaskill amacaskill merged commit 13b8eb9 into kubernetes-sigs:master Feb 23, 2024
@amacaskill
Copy link
Member

/cherry-pick release-1.13

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 23, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@amacaskill: new pull request created: #1622

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sneha-at Sneha-at mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwschuurman pwschuurman pwschuurman left review comments

@amacaskill amacaskill Awaiting requested review from amacaskill

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@songjiaxun songjiaxun Awaiting requested review from songjiaxun

Assignees

@pwschuurman pwschuurman

@amacaskill amacaskill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sneha-at @pwschuurman @k8s-ci-robot @amacaskill @k8s-infra-cherrypick-robot