Skip to content

Change DisableDevice error to warning #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2023
Merged

Change DisableDevice error to warning #1467

merged 1 commit into from
Oct 26, 2023

Conversation

mattcary
Copy link
Contributor

/kind cleanup

The benign error when DisableDevice is not effective is logged as a warning.

@mattcary
Change DisableDevice error to warning
4232a41 
Change-Id: I3b6e586610d3f20e86b7f20bf099b6ee2451d11a
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2023
@mattcary
Copy link
Contributor Author

/assign @Sneha-at

@Sneha-at
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 728ed49 into kubernetes-sigs:master Oct 26, 2023
@mattcary
Copy link
Contributor Author

/cherry-pick release-1.12

@mattcary
Copy link
Contributor Author

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 26, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@mattcary: new pull request created: #1468

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 26, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@mattcary: new pull request created: #1469

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacaskill amacaskill Awaiting requested review from amacaskill

@leiyiz leiyiz Awaiting requested review from leiyiz

Assignees

@Sneha-at Sneha-at

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattcary @k8s-ci-robot @Sneha-at @k8s-infra-cherrypick-robot