Skip to content

Commit 728ed49

Browse files
authored
Merge pull request #1467 from mattcary/warn
Change DisableDevice error to warning
2 parents e5c925d + 4232a41 commit 728ed49

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/gce-pd-csi-driver/node.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -397,9 +397,9 @@ func (ns *GCENodeServer) NodeUnstageVolume(ctx context.Context, req *csi.NodeUns
397397
klog.Errorf("Failed to find device path for volume %s. Device may not be detached cleanly (error is ignored and unstaging is continuing): %v", volumeID, err.Error())
398398
} else {
399399
if devFsPath, err := filepath.EvalSymlinks(devicePath); err != nil {
400-
klog.Errorf("filepath.EvalSymlinks(%q) failed when trying to disable device: %w (ignored, unstaging continues)", devicePath, err)
400+
klog.Warningf("filepath.EvalSymlinks(%q) failed when trying to disable device: %w (ignored, unstaging continues)", devicePath, err)
401401
} else if err := ns.DeviceUtils.DisableDevice(devFsPath); err != nil {
402-
klog.Errorf("Failed to disabled device %s (aka %s) for volume %s. Device may not be detached cleanly (error is ignored and unstaging is continuing): %w", devicePath, devFsPath, volumeID, err)
402+
klog.Warningf("Failed to disabled device %s (aka %s) for volume %s. Device may not be detached cleanly (ignored, unstaging continues): %w", devicePath, devFsPath, volumeID, err)
403403
}
404404
}
405405

0 commit comments

Comments
 (0)