Skip to content

Automated cherry pick of #1150 #1232 #1227 on release-1.9. #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented May 26, 2023

Cherry pick of #1150 #1232 #1227 on release-1.9.

#1150: satisfy volume cloning topology requirements when choosing zone for CreateVolume
#1232: Use errors.As so we can detect wrapped errors, and check for
#1227: Adding new metric pdcsi_operation_errors to fetch error

For details on the cherry pick process, see the cherry pick requests page.

#1150: satisfy volume cloning topology requirements when choosing zone for CreateVolume

#1232: Use errors.As so we can detect wrapped errors

#1227: Adding new metric pdcsi_operation_errors to fetch error

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 26, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 26, 2023
@sunnylovestiramisu sunnylovestiramisu force-pushed the automated-cherry-pick-of-#1232-#1227-upstream-release-1.9 branch from 24fb3ba to fe62f32 Compare May 26, 2023 17:42
@sunnylovestiramisu sunnylovestiramisu changed the title Automated cherry pick of #1232: Use errors.As so we can detect wrapped errors, and check for #1227: Adding new metric pdcsi_operation_errors to fetch error Automated cherry pick of #1232: Use errors.As so we can detect wrapped errors, and check for#1227: Adding new metric pdcsi_operation_errors to fetch error May 26, 2023
@sunnylovestiramisu sunnylovestiramisu changed the title Automated cherry pick of #1232: Use errors.As so we can detect wrapped errors, and check for#1227: Adding new metric pdcsi_operation_errors to fetch error Automated cherry pick of #1150 #1232 #1227 on release-1.9. May 26, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 26, 2023
@sunnylovestiramisu
Copy link
Contributor Author

/assign @amacaskill

@amacaskill
Copy link
Member

amacaskill commented May 26, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2023
@amacaskill
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@judemars
Copy link
Contributor

judemars commented Aug 3, 2023

Just a note here for posterity: this affectively also backports #1230 since it adds error wrapping for deadlineexceeded and cancelled.

@sunnylovestiramisu sunnylovestiramisu deleted the automated-cherry-pick-of-#1232-#1227-upstream-release-1.9 branch March 15, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants